β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-5279

pci_get_vpd_readonly_method(): missing break discards every successful keyword match β€” lookup always returns ENXIO

Summary

The search loop stores *vptr on match but has no break; the post-loop i!=rocnt test is always false so the function NULLs *vptr and returns ENXIO even for present keywords. FreeBSD breaks; DFly dropped it. Drivers relying on PCI_GET_VPD_READONLY (e.g. VPD MAC addresses) silently fail. Demonstrated in the DF-5276 harness (ENXIO pre-fix, value post-fix). Add-the-break fix.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-5279 Β· 1 files
FileTypeDescriptionSize
verdict.json file 1007 B view raw

Fix verification

not_testable
baseline no→ patch + rebuild →patched clean
per-fix-DF-5279

Confirmed kernel references

Detail

Evidence (decisive lines)

static trace (DF-5279 also run.t2.log stage 2a in findings/poc/DF-5276/)

Verified recommended fix

see finding markdown

Verdict

untested (Low functional / Low legacy-HW race / Info boot-time; demonstrated in DF-5276 harness where applicable)