DF-4902 — iceland_ih: unvalidated device-DMA'd IH wptr (DF-4843/DF-4854/DF-4887 5th twin)

File: sys/dev/drm/amd/amdgpu/iceland_ih.c (Topaz/Iceland discrete parts, selected at vi.c:1600)

Iceland is the 5th member of the unvalidated-wptr IH family. All five IH implementations in the tree (cik, tonga, iceland, cz, vega10) share the same defect; after this filing every implementation is covered — none validates wptr alignment.

Reproduce

Not runnable on the audit guest: the wptr is DMA'd by the GPU into the host writeback slot (adev->wb.wb[adev->irq.ih.wptr_offs], iceland_ih.c:192); the QEMU guest has no AMD GPU (env.txt). Code-certain by inspection — diff of the vulnerable block against the filed twins is empty except for the function prefix (see VERDICT.md — iceland_ih.c is byte-identical to cz_ih.c in all vulnerable logic).

The two defects (identical shape to the filed twins)

1. Permanent interrupt-thread spin — iceland_ih_get_wptr returns wptr & ptr_mask only (iceland_ih.c:207). A wptr with phase 1..15 (mod 16) can never equal the 16-byte-stepping rptr in the shared walk (amdgpu_ih.c:154-157) → the amdgpu ithread re-dispatches the whole ring forever, all GPU interrupt delivery dead.
2. Ring-end OOB read via RB_OVERFLOW recovery — recovery parks rptr = (wptr + 16) & ptr_mask (iceland_ih.c:202), importing the misaligned phase. For wptr' in [0xFFE4..0xFFEF]|OVERFLOW, rptr lands on [0xFFF4..0xFFFF] and the first decode (iceland_ih.c:253-256) reads up to 12 bytes past the exact-64KiB GTT ring BO (iceland_ih.c:300 / amdgpu_ih.c:80-88).

Artifacts

trigger_sketch.c (hostile-device pattern), fix.diff (alignment normalize + bounded walk), VERDICT.md, manifest.json, verdict.json, env.txt

DF-4902 VERDICT — iceland_ih.c 4th twin

status: untested (device-gated) | impact ceiling: dos + 12-byte OOB ring read | confidence: certain

Why untested

The audit guest (QEMU, no AMD GPU — env.txt) cannot instantiate iceland_ih (selected only for CHIP_TOPAZ at vi.c:1600), and the wptr source is device-side DMA into the host writeback slot (adev->wb.wb[adev->irq.ih.wptr_offs], iceland_ih.c:192, targeted by the writeback programmed at iceland_ih.c:133-138). Guest software cannot produce the trigger.

Why certain (code identity with filed twins)

• iceland_ih.c vs iceland_ih.c: byte-identical get_wptr/prescreen/decode/set_rptr (only OSS register headers and ip-block version differ) — see twin_diff.cz-vs-tonga.txt for the cz-vs-tonga shape (tonga = DF-4843, filed; tonga additionally has the use_bus_addr branch CZ lacks — CZ is the wb-only variant, no IH doorbell on CZ).
• Defect 1 (spin): iceland_ih.c:207 returns wptr & ptr_mask — no 16-byte alignment check; the shared walker (amdgpu_ih.c:154-157) steps rptr by 16 (iceland_ih.c:266 decode; iceland_ih.c:234 prescreen) so a wptr ≡ 4..15 (mod 16) can never be matched → permanent ithread spin, all GPU IRQs dead.
• Defect 2 (OOB): iceland_ih.c:202 parks rptr=(wptr+16)&0xFFFF with the wptr's misaligned phase; wptr' ∈ [0xFFE4..0xFFEF]|OVERFLOW → rptr ∈ [0xFFF4..0xFFFF] → first decode (iceland_ih.c:253-256) reads ring dwords [0x3FFD..0x4002] — up to 12 bytes past the exact-64KiB GTT ring BO allocated at iceland_ih.c:300 via amdgpu_ih.c:80-88 (no slack), consumed as an IV and dispatched.

Family sweep conclusion

All five IH implementations (cik DF-4887, tonga DF-4843, vega10 DF-4854, cz DF-4902, iceland DF-4902) share the defect; after this filing and DF-4902 none remains unfiled. No IH implementation validates wptr alignment. Fix: normalize wptr alignment in each get_wptr (fix.diff here) + cap the shared walk (DF-4887's amdgpu_ih.c half).

Fix status (batch validation)

Applied with the 36 sibling fix.diffs of this batch in findings/poc/_batch41/all_fixes.patch; single in-guest make -j6 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with zero errors under -Werror (full log: findings/poc/_batch41/fix_build8.log). Behavior A/B intentionally skipped for this Info-tier item.