polaris10 VCE/UVD/CAC level population NULL-derefs when the PowerPlay table omits usMMDependencyTableOffset / usVddcLookupTableOffset
Summary
fiji DF-4006 / DF-3685 family on polaris: the parser leaves mm_dep_table NULL and vddc_lookup_table NULL with parse result 0, but polaris10_init_smc_table unconditionally reaches mm_table->count and lookup_table->count - NULL-page fault during attach/resume. Guest-demonstrated (child SIGSEGV). NULL-check fix.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-4040 Β· 12 files| File | Type | Description | Size | |
|---|---|---|---|---|
| polaris_walks.c | β | 19.5 KB | view raw | |
| build.sh | β | 65 B | view raw | |
| run.sh | β | 89 B | view raw | |
| build.log | β | 0 B | β download | |
| run.log | β | 4.8 KB | view raw | |
| env.txt | β | 533 B | view raw | |
| fix.diff | β | 953 B | view raw | |
| fix_build.log | β | 1.2 KB | view raw | |
| README.md | β | 1.1 KB | β raw | |
| VERDICT.md | β | 2.4 KB | β raw | |
| manifest.json | β | 1.1 KB | view raw | |
| verdict.json | β | 3.6 KB | view raw |
DF-4040 β polaris10 VCE/UVD/CAC level population NULL-derefs when the PowerPlay table omits the MM-dependency or VDDC-lookup subtable offsets
File: sys/dev/drm/amd/powerplay/smumgr/polaris10_smumgr.c
Severity: Low | Class: CWE-476 NULL Pointer Dereference
Status: hardware-gated β source-certain; runtime reproduction impossible on the audit guest
(no Polaris GPU / no AMD53C974 HBA β see env.txt). Verdict: inconclusive, confidence certain.
Build & run (on the DragonFly guest)
./build.sh # compiles the demonstrator (uses the guest's kernel headers) ./run.sh # reproduces the exact index arithmetic / branch selection
Expected: the DF-4040 section of run.log shows the OOB offsets / panic-branch selection / fault.
Full guest details in env.txt.
Fix validation
fix.diff applied (with all DF-4036..DF-4044 patches together) to a clean guest /usr/src copy;
make nativekernel KERNCONF=X86_64_GENERIC completed with 0 errors under -Werror
(see fix_build.log β polaris10_smumgr.o recompiled).
Sources restored to pristine afterwards (md5-verified).
DF-4040 VERDICT β polaris10 VCE/UVD/CAC level population NULL-derefs when the PowerPlay table omits the MM-dependency or VDDC-lookup subtable offsets
Bottom line
Source-certain NULL derefs, fiji DF-4006 / DF-3685 family on polaris: the V1 parser treats usMMDependencyTableOffset and usVddcLookupTableOffset as optional (mm table left NULL at process_pptables_v1_0.c:794-802, lookup at :281-288; parse result stays 0), but polaris10_init_smc_table unconditionally calls polaris10_populate_smc_vce_level (mm_table->count at polaris10_smumgr.c:1298), polaris10_populate_smc_uvd_level (:1404) and polaris10_populate_smc_voltage_tables -> polaris10_populate_cac_table (lookup_table->count at :712). Each faults on the NULL page during driver attach/resume -> kernel panic. Demonstrated (child SIGSEGV on the NULL deref): run.log DF-4040. Hardware-gated -> runtime inconclusive, source certain.
Exploit chain
crafted vBIOS PowerPlay table with usMMDependencyTableOffset==0 (or usVddcLookupTableOffset==0) -> parse OK -> polaris10_init_smc_table -> populate_* -> NULL->count page fault => panic
Why not reproduced on the guest
The audit guest is QEMU/KVM with virtio display only: no AMD GPU, /dev/dri absent (env.txt), so polaris10_powerplay never binds β the crafted-VBIOS trigger cannot be exercised at runtime. The index arithmetic and struct geometry are proven against the kernel headers compiled verbatim (run.log), and the fix is compile-validated (fix_build.log).
Negative results recorded alongside (pass-2 depth)
Checklist item kills: LinkLevel i<=count walk is bounded (pcie count clamped to <=7 at smu7_hwmgr.c:561-569); mc_reg-table walks are not in this file (smu7_smumgr.c owns them); fan-table div0 is known DF-1345; VCE/UVD count overflow is known DF-1346; Smio[32] and SmioTable.Pattern[4] walks are correctly clamped (SMU_MAX_SMIO_LEVELS).
Fix
NULL-check mm_table in the VCE/UVD populators (return -EINVAL) and lookup_table in the CAC populator (fix.diff). Applied and compile-validated on the guest (fix_build.log); sys/ tree never modified by the audit.
Fix status (batch validation)
Applied with the 36 sibling fix.diffs of this batch in findings/poc/_batch41/all_fixes.patch; single in-guest make -j6 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with zero errors under -Werror (full log: findings/poc/_batch41/fix_build8.log). Behavior A/B intentionally skipped for this Info-tier item.
Fix verification
fixedfixed (compile-validated): all nine patches applied together to the clean guest /usr/src copy (polaris10_smumgr.c md5 6f39bb32..->19a2b278.., amd.c f577a330..->54ce1518..), make -j4 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with 0 compile errors under -Werror; the patched polaris10_smumgr.o (amdgpu module) and amd.o (GENERIC kernel) both recompiled. Runtime re-test impossible on this guest (device absent). Sources restored to pristine and md5-verified after validation.
findings/poc/DF-4040/fix.diff; findings/poc/DF-4040/fix_build.log (build banner + compile lines + 0 errors)
Confirmed kernel references
Detail
Exploit chain
crafted vBIOS PowerPlay table with usMMDependencyTableOffset==0 (or usVddcLookupTableOffset==0) -> parse OK -> polaris10_init_smc_table -> populate_* -> NULL->count page fault => panic
Evidence (decisive lines)
run.log section DF-4040 (child signal 11); VERDICT.md; fix_build.log; env.txt
PoC changes
Pass-2 reviewer authored demonstrator compiling the kernel's own headers (smu74.h/smu74_discrete.h packed, or a verbatim copy of the driver's amdsentmsg/parsemsg arms) so struct geometry and branch selection are the kernel's; fix.diff generated against the pristine file and compile-validated via full nativekernel rebuild on the guest (shared build with DF-4036..DF-4044, fix_build.log).
Verified recommended fix
NULL-check mm_table in the VCE/UVD populators (return -EINVAL) and lookup_table in the CAC populator (fix.diff)
Verdict
Source-certain NULL derefs, fiji DF-4006 / DF-3685 family on polaris: the V1 parser treats usMMDependencyTableOffset and usVddcLookupTableOffset as optional (mm table left NULL at process_pptables_v1_0.c:794-802, lookup at :281-288; parse result stays 0), but polaris10_init_smc_table unconditionally calls polaris10_populate_smc_vce_level (mm_table->count at polaris10_smumgr.c:1298), polaris10_populate_smc_uvd_level (:1404) and polaris10_populate_smc_voltage_tables -> polaris10_populate_cac_table (lookup_table->count at :712). Each faults on the NULL page during driver attach/resume -> kernel panic. Demonstrated (child SIGSEGV on the NULL deref): run.log DF-4040. Hardware-gated -> runtime inconclusive, source certain.
No comments yet.