handle_workitem_freeblocks: indir_trunc errors silently swallowed — '== 0' dead store makes allerror unreachable, I/O errors during indirect-block deallocation unreported

Summary

In handle_workitem_freeblocks, the loop over indirect blocks assigns 'if ((error = indir_trunc(...)) == 0) allerror = error;' — error is only assigned into allerror when it is 0, so allerror can never become non-zero and the DIAGNOSTIC error report at :2188-2189 is dead code. Real read/deallocation failures of indirect blocks are silently dropped (frees of the containing indirect blocks still proceed), so a filesystem can go inconsistent after transient I/O errors with no kernel indication, unlike ffs_truncate which propagates indir-truncation errors. Inverted comparison (should be '!= 0'); one-character fix. Requires an underlying device I/O error during background deallocation — robustness/consistency defect, not attacker-controllable.

Timeline

• 2026-09-02 Discovered during pass-2 audit of ffs_softdep.c (GLM 5.3).