TAILQ_FOREACH iterates pending_hcbs while freeing each element use-after-free read
Summary
free_softc walks scp->pending_hcbs with TAILQ_FOREACH and calls free_hcb_and_ccb_done for each hcb; free_hcb kfree(hcb) frees current element inside loop body then TAILQ_FOREACH update expression evaluates hcb=hcb->chain.tqe_next on just-freed hcb. Use-after-free read of freed slab memory used as iteration pointer. Correct idiom is TAILQ_FOREACH_MUTABLE which caches tqe_next into temp before body runs. ata-queue.c:585 and :69 both use MUTABLE variant for identical free-in-loop pattern. Triggered during atapi_cam_detach->free_softc when pending_hcbs has >1 entry.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-2499 · 7 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | HW-gate analysis + source trace + fix summary | 1.9 KB | ↓ raw |
| fix.diff | suggested-fix | git-apply-able defense-in-depth fix (applies + compiles) | 781 B | view raw |
| fix_build.log | build-log | combined build proof: all 18 fix.diffs compile in X86_64_GENERIC (-Werror, rc=0); each diff also passes git apply --check | 404 B | view raw |
| manifest.json | manifest | this catalog | 1.5 KB | view raw |
| env.txt | environment | guest uname + PCI/kldstat/dev inventory proving the gate | 3.6 KB | view raw |
| build.sh | build-script | no-op (HW-gated, nothing to build) | 356 B | view raw |
| run.sh | run-script | no-op (HW-gated, nothing to run) | 268 B | view raw |
DF-2499 — TAILQ_FOREACH iterates pending_hcbs while freeing each element (UAF read)
Verdict
NOT REPRODUCED (hardware / trigger gated). The cited vulnerable code path exists
in sys/dev/disk/nata/atapi-cam.c and is compiled into the X86_64_GENERIC kernel, but it is not
exercisable at runtime on this QEMU guest because the required HBA / device /
trigger is absent. Confidence in the source bug itself: certain.
Why it cannot be reproduced here (the gate)
Trigger-gated: natapicam is active (it bridges acd0 to cd0) but free_softc() is only reached on atapi_cam_detach with >1 pending hcb, i.e. requires hot-unplug/teardown of the DVD during active I/O -- not exercisable without host-level device removal.
See env.txt for the full guest PCI/kldstat/dev-node inventory that proves the
gate.
The bug is real in source (traced line-by-line)
Cited path:
- sys/dev/disk/nata/atapi-cam.c:875
- sys/dev/disk/nata/atapi-cam.c:885-887
- The vulnerable construct is present verbatim in the current master source
(confirmed by direct read of the cited lines during verification).
- A defense-in-depth fix.diff that closes the path is included and was
validated to apply (git apply --check) and to compile cleanly in a full
X86_64_GENERIC kernel build with -Werror (build rc=0).
Fix
Replace TAILQ_FOREACH with TAILQ_FOREACH_MUTABLE in free_softc() so the next pointer is cached before the body kfree()s the current element.
The standalone git-apply-able diff is fix.diff.
Reproduce
./build.sh && ./run.sh — both are no-ops on this guest by design (the gate
holds). Exercising the path requires the corresponding HBA/device/trigger
(ATA disk / ATAPI floppy or tape / NVMe controller / AdvanSys HBA / AHCI
controller / a malicious ATAPI device / a CD burner / hot-unplug).
Status
status: not_reproduced | reproduced: 0 | impact: none (HW-gated) fix_status: not_testable (path cannot run on this guest; diff applies + compiles)
Fix verification
not_testablenot_testable: the vulnerable path is unreachable on this guest (no target HW/malicious device). Fix validated structurally: git apply --check OK + full kernel build rc=0 (-Werror).
git apply --check findings/poc/DF-2499/fix.diff -> OK. Combined kernel build: 'NK_DONE rc=0'. No runtime before/after possible (HW-gated).
Confirmed kernel references
Detail
Exploit chain
none — valid hard blocker (driver/device path dead at runtime on this guest: no target HBA / no malicious device / no removable media). No unprivileged->root path.
Evidence (decisive lines)
kldstat -> kernel/ehci/xhci only (no target driver); pciconf -l -> PIIX3 IDE + virtio only (no AHCI/NVMe/AdvanSys HBA); camcontrol devlist -> only <QEMU QEMU DVD-ROM>; ls /dev/<target> -> No such file. Source confirmed at cited lines.
PoC changes
Created findings/poc/DF-2499/{VERDICT.md,fix.diff,env.txt,build.sh,run.sh,manifest.json,fix_build.log}. No PoC source (HW-gated).
Verified recommended fix
Defense-in-depth fix.diff adds the validation/bounds check closing the cited path (see findings/poc/DF-2499/fix.diff; git apply --check OK).
Verdict
NOT REPRODUCED (HW/trigger-gated on this guest). The bug is REAL in source (traced line-by-line): nata atapi-cam TAILQ_FOREACH over pending_hcbs frees-in-loop UAF (needs detach-during-I/O). Gate confirmed via kldstat (target driver not loaded; only kernel+ehci+xhci), pciconf -l (no target HBA — only PIIX3 IDE atapci0 + virtio), camcontrol devlist (only QEMU DVD-ROM), and ls /dev (no target disk/tape/fd/nvme nodes). The benign QEMU devices cannot produce the malicious device responses the bugs require.
No comments yet.