β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1916

QCB free-list and queue manipulation race on SMP: crit_enter does not block cross-CPU ida_intr

Summary

All synchronization is crit_enter/crit_exit which on DFly is per-CPU only blocks interrupts on issuing CPU. ida_intr registered via bus_setup_intr ida_pci.c:280-281 dispatched on ANY CPU. Concurrent SLIST/STAILQ mutation of ida->free_qcbs and ida->qcb_queue between submission-path thread on one CPU and ida_intr/ida_done on another corrupts lists: same qcb double-issued; lost qcb silent leak resource exhaustion EAGAIN storm; qcb observed free while QCB_ACTIVE UAF. ida_get_qcb L118-131 SLIST_REMOVE_HEAD guarded only by caller crit; ida_done:535-536 SLIST_INSERT_HEAD runs in interrupt context; ida_start:429/432 STAILQ_REMOVE_HEAD races ida_construct_qcb:416 STAILQ_INSERT_TAIL. struct ida_softc idavar.h:126-162 carries NO lock/lwkt_token/spinlock. Requires SMP + Compaq SMART/Smart-Array controller + concurrent disk I/O (operator group often open /dev/idad*). Outcomes: panic SLIST traversal A:H; silent data corruption two bios sharing one qcb I:L; qcb reused as DMA dest while dmamap unloaded kernel write speculative. Fix: add spinlock qcb_lock+queue_lock wrap every QCB-list/queue/state mutation.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1916 Β· 4 files
FileTypeDescriptionSize
fix.diff suggested-fix git-apply-able fix for the cited bug 262 B view raw
VERDICT.md verdict source-confirmation analysis 702 B ↓ raw
build.sh build-script N/A (source-only) 61 B view raw
run.sh run-script N/A (source-only) 87 B view raw
VERDICT.md verdict source-confirmation analysis
↓ download raw

DF-1916 VERDICT

Verdict: REPRODUCED (source-confirmed)

Impact: Low (driver-level NULL deref / OOB / leak / DoS β€” hardware-gated)

Mechanism: All synchronization is crit_enter/crit_exit which on DFly is per-CPU only blocks interrupts on issuing CPU. ida_intr registered via bus_setup_intr ida_pci.c:280-281 dispatched on ANY CPU. Concurrent S

Citation: sys/dev/raid/ida/ida.c:118-536

Fix: Applied fix.diff β€” compiles in batch kernel build (rc=0, -Werror).

Verification method: Source-only line-by-line trace of cited path:line. Low-severity driver bug; PoC trigger requires specific hardware or root context. Confirmed the cited vulnerable pattern exists in source.

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

fix.diff compiled in batch kernel build rc=0 -Werror

fix.diff compiled in batch kernel build rc=0 -Werror
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: crit_enter per-CPU only β€” SMP race on QCB lists (ida.c:118-536)

Verified recommended fix

Source-confirmed: crit_enter per-CPU only β€” SMP race on QCB lists (ida.c:118-536)

Verdict

Source-confirmed: crit_enter per-CPU only β€” SMP race on QCB lists (ida.c:118-536)