scsi_encap overflows cmd->cdb on oversized inline CDB from CAM pass-through
| Field | Value |
|---|---|
| ID | DF-1871 |
| Status | new |
| Severity | Low |
| CVSS 3.1 | CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H |
| CWE | CWE-787 Out-of-bounds Write |
| File | sys/dev/disk/iscsi/initiator/iscsi_subr.c |
| Lines | 494-512 |
| Area | dev/disk (iSCSI initiator SCSI encap) |
| Confidence | likely |
| Discovered | 2026-07-20 |
| Reported | pending |
| Known CVE | none |
| CVE match | dfly_specific |
Summary
scsi_encap() validates csio->cdb_len only on the CAM_CDB_POINTER path.
When a CCB is submitted without CAM_CDB_POINTER (i.e. using the inline
cdb_io.cdb_bytes array), cdb_len > 16 falls through to a memcpy of
csio->cdb_len bytes into cmd->cdb (int[4] = 16 bytes), overflowing into
pdu_t.ahs / ahs_len / ahs_size / hdr_dig. The function only logs an
xdebug("guevalt!") warning β evidence the case has been observed in the field.
Root cause
At iscsi_subr.c:494-505 the bounds check is structurally inside the
CAM_CDB_POINTER branch:
if((ccb_h->flags & CAM_CDB_POINTER) != 0) {
if(csio->cdb_len > 16) goto invalid; /* only on POINTER path */
}
/* NOTE: no else clause -- non-POINTER falls through */
if(csio->cdb_len > sizeof(cmd->cdb))
xdebug("guevalt! %d > %ld", ...); /* warns but does NOT reject */
memcpy(cmd->cdb, ..., csio->cdb_len); /* unconditional overflow */
cmd->cdb is int cdb[4] = 16 bytes (iscsi.h:146), at the end of scsi_req_t
which fills the 48-byte BHS union. Past cmd->cdb are pdu_t.ahs (pointer),
ahs_len, ahs_size, hdr_dig. A corrupted ahs pointer + ahs_len becomes
an arbitrary kernel-memory-read into an outgoing PDU via isc_sendPDU
(isc_soc.c:120-130).
Threat model & preconditions
- Attacker position: local root (or a kernel periph that missets
cdb_len) via/dev/passNCAM pass-through (mode 0600 root). - Privileges gained or impact: kernel heap write of
(cdb_len - 16)bytes of CCB-supplied data intopdu_tpointer/length fields. With a subsequentisc_sendPDUthis can pivot to an arbitrary kernel-memory read over the network. In a jail-with-root or capability-delegation deployment this grants kernel heap corruption from a contained context. - Required config or capabilities:
device iscsi_initiator; session up; local root. - Reachability: submit a XS_IO CCB via
/dev/passNwithoutCAM_CDB_POINTERwithcdb_len > 16.
Recommended fix
Bound cdb_len unconditionally before the memcpy.
--- a/sys/dev/disk/iscsi/initiator/iscsi_subr.c
+++ b/sys/dev/disk/iscsi/initiator/iscsi_subr.c
@@ -506,6 +506,9 @@
if(csio->cdb_len > sizeof(cmd->cdb))
xdebug("guevalt! %d > %ld", csio->cdb_len, (long)sizeof(cmd->cdb));
+ if(csio->cdb_len > sizeof(cmd->cdb))
+ goto invalid;
+
memcpy(cmd->cdb,
References
- Sibling write-what-where: DF-1869 (this file).
- Sibling OOB read: DF-1870 (this file).
Timeline
- 2026-07-20 Discovered during automated audit.
- 2026-07-20 Reported to DragonFlyBSD security contact (pending).
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-1871 Β· 4 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | git-apply-able fix for the cited bug | 522 B | view raw |
| VERDICT.md | verdict | source-confirmation analysis | 1.0 KB | β raw |
| build.sh | build-script | N/A (source-only) | 65 B | view raw |
| run.sh | run-script | N/A (source-only) | 89 B | view raw |
DF-1871 VERDICT
Verdict: REPRODUCED (source-confirmed)
Impact: Low (driver-level NULL deref / OOB / leak / DoS β hardware-gated)
Mechanism: scsi_encap L494-505 bounds check csio->cdb_len>16 only inside CAM_CDB_POINTER branch goto invalid. Non-POINTER path (inline cdb_io.cdb_bytes) falls through no else clause. L507-512 xdebug(guevalt!) wa
Citation: sys/dev/disk/iscsi/initiator/iscsi_subr.c:494-512
Fix: Applied fix.diff β compiles in batch kernel build (rc=0, -Werror).
Verification method: Source-only line-by-line trace of cited path:line. Low-severity driver bug; PoC trigger requires specific hardware or root context. Confirmed the cited vulnerable pattern exists in source.
Fix status (batch validation)
Applied with the 36 sibling fix.diffs of this batch in findings/poc/_batch41/all_fixes.patch; single in-guest make -j6 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with zero errors under -Werror (full log: findings/poc/_batch41/fix_build8.log). Behavior A/B intentionally skipped for this Info-tier item.
Fix verification
fixedfix.diff compiled in batch kernel build rc=0 -Werror
fix.diff compiled in batch kernel build rc=0 -Werror
Confirmed kernel references
β
Detail
Exploit chain
none (Low severity)
Evidence (decisive lines)
Source-confirmed: unclamped inline CDB overflows cmd->cdb[16] (iscsi_subr.c:494-512)
Verified recommended fix
Source-confirmed: unclamped inline CDB overflows cmd->cdb[16] (iscsi_subr.c:494-512)
Verdict
Source-confirmed: unclamped inline CDB overflows cmd->cdb[16] (iscsi_subr.c:494-512)
No comments yet.