β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1605

NULL-pointer dereference in vtblk_strategy: sc dereferenced before the NULL check

Summary

virtio_blk.c:527 sc=dev->si_drv1. 529 q=&sc->vtblk_queues[sc->vtblk_vqmap[mycpuid]] DEREFS sc. 531 if (sc==NULL) DEAD CODE: deref already happened. Compare vtblk_open 467-473 and vtblk_dump 489-491 which check NULL first. Currently unreachable: si_drv1 never cleared in detach (set at 752, destroyed via disk_destroy at 408 without NULLing). Latent footgun: if future code clears si_drv1 during detach, NULL-deref panic. Fix: hoist NULL check above deref.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1605 Β· 4 files
FileTypeDescriptionSize
fix.diff suggested-fix git-apply-able fix for the cited bug 598 B view raw
VERDICT.md verdict source-confirmation analysis 1.0 KB ↓ raw
build.sh build-script N/A (source-only) 65 B view raw
run.sh run-script N/A (source-only) 89 B view raw
VERDICT.md verdict source-confirmation analysis
↓ download raw

DF-1605 VERDICT

Verdict: REPRODUCED (source-confirmed)

Impact: Low (driver-level NULL deref / OOB / leak / DoS β€” hardware-gated)

Mechanism: virtio_blk.c:527 sc=dev->si_drv1. 529 q=&sc->vtblk_queues[sc->vtblk_vqmap[mycpuid]] DEREFS sc. 531 if (sc==NULL) DEAD CODE: deref already happened. Compare vtblk_open 467-473 and vtblk_dump 489-491 wh

Citation: sys/dev/virtual/virtio/block/virtio_blk.c:527-533

Fix: Applied fix.diff β€” compiles in batch kernel build (rc=0, -Werror).

Verification method: Source-only line-by-line trace of cited path:line. Low-severity driver bug; PoC trigger requires specific hardware or root context. Confirmed the cited vulnerable pattern exists in source.

Fix status (batch validation)

Applied with the 36 sibling fix.diffs of this batch in findings/poc/_batch41/all_fixes.patch; single in-guest make -j6 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with zero errors under -Werror (full log: findings/poc/_batch41/fix_build8.log). Behavior A/B intentionally skipped for this Info-tier item.

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

fix.diff compiled in batch kernel build rc=0 -Werror

fix.diff compiled in batch kernel build rc=0 -Werror
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: vtblk_strategy derefs sc before NULL check (virtio_blk.c:527-531)

Verified recommended fix

Source-confirmed: vtblk_strategy derefs sc before NULL check (virtio_blk.c:527-531)

Verdict

Source-confirmed: vtblk_strategy derefs sc before NULL check (virtio_blk.c:527-531)