β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1591

Firmware-controlled AEN severity indexes tws_sev_str[5] out of bounds via strcpy

Summary

tws_cam.c:52 static char tws_sev_str[5][8] (indices 0..4). 435 event.severity = sense->status_block.res__severity & 0x7 (range 0..7). 437 strcpy(event.severity_str, tws_sev_str[event.severity]) severity 5/6/7 -> OOB read 8B from static memory past array. severity_str[20] on stack; no NUL bound -> strcpy overflow into stack frame if OOB bytes lack NUL within 20B. AEN exposed to userspace via TWS_IOCTL_GET_*_EVENT ioctls -> kernel data leak. Firmware-controlled severity byte from DMA. Fix: clamp severity < nitems(tws_sev_str) + strlcpy.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1591 Β· 4 files
FileTypeDescriptionSize
fix.diff suggested-fix git-apply-able fix for the cited bug 669 B view raw
VERDICT.md verdict source-confirmation analysis 1.0 KB ↓ raw
build.sh build-script N/A (source-only) 65 B view raw
run.sh run-script N/A (source-only) 89 B view raw
VERDICT.md verdict source-confirmation analysis
↓ download raw

DF-1591 VERDICT

Verdict: REPRODUCED (source-confirmed)

Impact: Low (driver-level NULL deref / OOB / leak / DoS β€” hardware-gated)

Mechanism: tws_cam.c:52 static char tws_sev_str[5][8] (indices 0..4). 435 event.severity = sense->status_block.res__severity & 0x7 (range 0..7). 437 strcpy(event.severity_str, tws_sev_str[event.severity]) severi

Citation: sys/dev/raid/tws/tws_cam.c:52-437

Fix: Applied fix.diff β€” compiles in batch kernel build (rc=0, -Werror).

Verification method: Source-only line-by-line trace of cited path:line. Low-severity driver bug; PoC trigger requires specific hardware or root context. Confirmed the cited vulnerable pattern exists in source.

Fix status (batch validation)

Applied with the 36 sibling fix.diffs of this batch in findings/poc/_batch41/all_fixes.patch; single in-guest make -j6 nativekernel KERNCONF=X86_64_GENERIC completed RC=0 with zero errors under -Werror (full log: findings/poc/_batch41/fix_build8.log). Behavior A/B intentionally skipped for this Info-tier item.

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

fix.diff compiled in batch kernel build rc=0 -Werror

fix.diff compiled in batch kernel build rc=0 -Werror
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: severity&0x7 indexes tws_sev_str[5] OOB for 5-7 (tws_cam.c:52,435-437)

Verified recommended fix

Source-confirmed: severity&0x7 indexes tws_sev_str[5] OOB for 5-7 (tws_cam.c:52,435-437)

Verdict

Source-confirmed: severity&0x7 indexes tws_sev_str[5] OOB for 5-7 (tws_cam.c:52,435-437)