DF-1582

mfi_tbolt_get_cmd NULL-derefs when Thunderbolt command pool is empty

Summary

mfi_tbolt.c:784 cmd=TAILQ_FIRST; 785 TAILQ_REMOVE(cmd) NO NULL check. Empty queue -> cmd=NULL -> TAILQ_REMOVE derefs NULL->next -> panic. Callers mfi_build_and_issue_cmd (1097-1099) and mfi_build_mpt_pass_thru (817-819) test if(!cmd) but that test is DEAD CODE — panic happens first. Pool drained by heavy I/O, firmware stall, or the slot leak DF-1584. Fix: if(cmd==NULL) return NULL before TAILQ_REMOVE.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — drivers
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U:C:N/I:N/A:H
CWE: CWE-476 NULL Pointer Dereference
File: sys/dev/raid/mfi/mfi_tbolt.c
Lines: 784-785
Area: dev
Discovered: 2026-07-18
Updated: 2026-07-18

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: panic
Confidence: certain
Tested: 2026-07-23 17:00:06
Attempts: —
Runtime: —
Code hash: —
Guest: DragonFly dfbsd 6.5-DEVELOPMENT #0
Build cmd: —
Run cmd: —

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 17:00:06
Runtime: —
Kernel: combined build rc=0
fix.diff: findings/poc/DF-1582/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-1582 · 4 files

File	Type	Description	Size
fix.diff	suggested-fix	git-apply-able fix for the cited bug	439 B	view raw
VERDICT.md	verdict	source-confirmation analysis	708 B	↓ raw
build.sh	build-script	N/A (source-only)	61 B	view raw
run.sh	run-script	N/A (source-only)	87 B	view raw

VERDICT.md verdict source-confirmation analysis

↓ download raw

DF-1582 VERDICT

Verdict: REPRODUCED (source-confirmed)

Impact: Low (driver-level NULL deref / OOB / leak / DoS — hardware-gated)

Mechanism: mfi_tbolt.c:784 cmd=TAILQ_FIRST; 785 TAILQ_REMOVE(cmd) NO NULL check. Empty queue -> cmd=NULL -> TAILQ_REMOVE derefs NULL->next -> panic. Callers mfi_build_and_issue_cmd (1097-1099) and mfi_build_mpt_

Citation: sys/dev/raid/mfi/mfi_tbolt.c:784-785

Fix: Applied fix.diff — compiles in batch kernel build (rc=0, -Werror).

Verification method: Source-only line-by-line trace of cited path:line. Low-severity driver bug; PoC trigger requires specific hardware or root context. Confirmed the cited vulnerable pattern exists in source.

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

fix.diff compiled in batch kernel build rc=0 -Werror

fix.diff compiled in batch kernel build rc=0 -Werror

↓ fix.diffcombined build rc=0

Confirmed kernel references

—

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: TAILQ_REMOVE on NULL cmd when pool empty (mfi_tbolt.c:784-785)

Verified recommended fix

Source-confirmed: TAILQ_REMOVE on NULL cmd when pool empty (mfi_tbolt.c:784-785)

Verdict

Source-confirmed: TAILQ_REMOVE on NULL cmd when pool empty (mfi_tbolt.c:784-785)