DF-1462

ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication of lba_mid_exp assignment

Summary

sili_xpt_scsi_disk_io ATA_PASS_16 at sili_cam.c:1219: fis->lba_mid_exp=atp16->lba_mid_ext (duplicate of :1217). Should be fis->lba_high_exp=atp16->lba_high_ext. LBA bits 40-47 always 0. Silent wrong-sector for ATA passthrough on >512TB disks. Also missing fis->control assignment. Twin of DF-1443 (ahci_cam.c:1320 identical bug). Fix: correct the assignment.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — drivers
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:U:C:N/I:L/A:L
CWE: CWE-682 Incorrect Calculation
File: sys/dev/disk/sili/sili_cam.c
Lines: 1217-1219
Area: dev
Discovered: 2026-07-17
Updated: 2026-07-17

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: certain
Tested: 2026-07-23 15:26:23
Attempts: —
Runtime: —
Code hash: —
Guest: DragonFly dfbsd 6.5-DEVELOPMENT #0
Build cmd: —
Run cmd: —

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 15:26:23
Runtime: —
Kernel: combined build rc=0
fix.diff: findings/poc/DF-1462/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-1462 · 2 files

File	Type	Description	Size
VERDICT.md	verdict	verification verdict	895 B	↓ raw
fix.diff	suggested-fix	git-apply-able fix	453 B	view raw

VERDICT.md verdict verification verdict

↓ download raw

DF-1462 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: certain

Finding

ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication of lba_mid_exp assignment

Source Location

sys/dev/disk/sili/sili_cam.c:1217-1219

Verdict

Source-confirmed: ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication o. Fix applies and compiles.

Fix Status

fixed: VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

Summary

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

↓ fix.diffcombined build rc=0

Confirmed kernel references

—

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: sili_cam ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication of lba_mid_exp assignment. Fixed to lba_high_exp=lba_high_ext. HW-gated.

Verified recommended fix

Source-confirmed: sili_cam ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication of lba_mid_exp assignment. Fixed to lba_high_exp=lba_high_ext. HW-gated.

Verdict

Source-confirmed: sili_cam ATA_PASS_16 FIS lba_high_exp never set due to copy-paste duplication of lba_mid_exp assignment. Fixed to lba_high_exp=lba_high_ext. HW-gated.