β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1440

NULL ddc_bus dereference in amdgpu_connector_get_edid for connectors with failed I2C bus init

Summary

amdgpu_connector_get_edid at amdgpu_connectors.c:296/305: ddc_bus->has_aux derefs ddc_bus which is NULL when I2C bus init fails (amdgpu_i2c_lookup returns NULL or valid=false). DP bridge and DP/eDP paths. Reached via DRM_IOCTL_MODE_GETCONNECTOR (unprivileged). VBIOS misconfiguration with DP bridge encoder but no matching I2C bus. Fix: add ddc_bus!=NULL before has_aux deref.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1440 Β· 2 files
FileTypeDescriptionSize
VERDICT.md verdict verification verdict 924 B ↓ raw
fix.diff suggested-fix git-apply-able fix 357 B view raw
VERDICT.md verdict verification verdict
↓ download raw

DF-1440 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: certain

Finding

NULL ddc_bus dereference in amdgpu_connector_get_edid for connectors with failed I2C bus init

Source Location

sys/dev/drm/amd/amdgpu/amdgpu_connectors.c:296-305

Verdict

Source-confirmed: NULL ddc_bus dereference in amdgpu_connector_get_edid for connectors w. Fix applies and compiles.

Fix Status

fixed: VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

Summary

amdgpu_connector_get_edid at amdgpu_connectors.c:296/305: ddc_bus->has_aux derefs ddc_bus which is NULL when I2C bus init fails (amdgpu_i2c_lookup returns NULL or valid=false). DP bridge and DP/eDP paths. Reached via DRM_IOCTL_MODE_GETCONNECTOR (unprivileged). VBIOS misconfiguration with DP bridge encoder but no matching I2C bus. Fix: add ddc_bus!=NULL before has_aux deref.

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: amdgpu_connector_get_edid dereferences amdgpu_connector->ddc_bus->has_aux without checking ddc_bus!=NULL for connectors with failed I2C bus init. Added NULL check. HW-gated.

Verified recommended fix

Source-confirmed: amdgpu_connector_get_edid dereferences amdgpu_connector->ddc_bus->has_aux without checking ddc_bus!=NULL for connectors with failed I2C bus init. Added NULL check. HW-gated.

Verdict

Source-confirmed: amdgpu_connector_get_edid dereferences amdgpu_connector->ddc_bus->has_aux without checking ddc_bus!=NULL for connectors with failed I2C bus init. Added NULL check. HW-gated.