DF-1421

firmware_get() reference never released on attach-failure or detach (refcount leak)

Summary

isp_pci_attach at isp_pci.c:856/859/868: firmware_get() up to 3x, isp->isp_osinfo.fw assigned. No firmware_put() in bad: label (:969-993) or detach (:996-1032). grep firmware_put across sys/dev/disk/isp/ returns zero. Refcount grows with each kldload/kldunload cycle. Root/module loading only. Fix: firmware_put in bad: and detach.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — drivers
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:U:C:N/I:N/A:L
CWE: CWE-772 Missing Release of Resource after Effective Lifetime
File: sys/dev/disk/isp/isp_pci.c
Lines: 856-1013
Area: dev
Discovered: 2026-07-17
Updated: 2026-07-17

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: certain
Tested: 2026-07-23 15:26:20
Attempts: —
Runtime: —
Code hash: —
Guest: DragonFly dfbsd 6.5-DEVELOPMENT #0
Build cmd: —
Run cmd: —

jump to evidence pack ↓

Fix verification

not_testable

Fix status: not_testable
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 15:26:21
Runtime: —
Kernel: combined build rc=0
fix.diff: findings/poc/DF-1421/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-1421 · 1 files

File	Type	Description	Size
VERDICT.md	verdict	verification verdict	839 B	↓ raw

VERDICT.md verdict verification verdict

↓ download raw

DF-1421 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: certain

Finding

firmware_get() reference never released on attach-failure or detach (refcount leak)

Source Location

sys/dev/disk/isp/isp_pci.c:856-1013

Verdict

Source-confirmed (complex fix): firmware_get() reference never released on attach-failure or detach (r. No diff in batch.

Fix Status

not_applicable: source defect confirmed; complex fix not included in batch build

Summary

Fix verification

not_testable

baseline reproduced→ patch + rebuild →patched clean

source defect confirmed; complex fix not included in batch build

source defect confirmed; complex fix not included in batch build

combined build rc=0

Confirmed kernel references

—

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: isp_pci firmware_get() reference stored in isp->isp_osinfo.fw never released on attach-failure or detach, refcount leak. Complex fix. HW-gated.

Verified recommended fix

Source-confirmed: isp_pci firmware_get() reference stored in isp->isp_osinfo.fw never released on attach-failure or detach, refcount leak. Complex fix. HW-gated.

Verdict

Source-confirmed: isp_pci firmware_get() reference stored in isp->isp_osinfo.fw never released on attach-failure or detach, refcount leak. Complex fix. HW-gated.