DF-1355

Inverted assertion in vega12_display_configuration_changed_task (functional bug)

Summary

vega12_display_configuration_changed_task at vega12_hwmgr.c:2114: PP_ASSERT_WITH_CODE(result,...). PP_ASSERT fires when cond is FALSE. result==0 (success) triggers EINVAL return, WaterMarksLoaded never set. result!=0 (failure) falls through, sets WaterMarksLoaded, masks failure. vega20 :2963 correctly uses !result. vega10 :4371 same bug. Fix: change result to !result.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — drivers
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U:C:N/I:N/A:N
CWE: CWE-480 Use of Incorrect Operator
File: sys/dev/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
Lines: 2112-2115
Area: dev
Discovered: 2026-07-17
Updated: 2026-07-17

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: certain
Tested: 2026-07-23 15:26:18
Attempts: —
Runtime: —
Code hash: —
Guest: DragonFly dfbsd 6.5-DEVELOPMENT #0
Build cmd: —
Run cmd: —

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 15:26:18
Runtime: —
Kernel: combined build rc=0
fix.diff: findings/poc/DF-1355/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-1355 · 2 files

File	Type	Description	Size
VERDICT.md	verdict	verification verdict	911 B	↓ raw
fix.diff	suggested-fix	git-apply-able fix	595 B	view raw

VERDICT.md verdict verification verdict

↓ download raw

DF-1355 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: certain

Finding

Inverted assertion in vega12_display_configuration_changed_task (functional bug)

Source Location

sys/dev/drm/amd/powerplay/hwmgr/vega12_hwmgr.c:2112-2115

Verdict

Source-confirmed: Inverted assertion in vega12_display_configuration_changed_task (funct. Fix applies and compiles.

Fix Status

fixed: VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

Summary

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

↓ fix.diffcombined build rc=0

Confirmed kernel references

—

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: vega12_display_configuration_changed_task PP_ASSERT_WITH_CODE(result,...) uses result (0=success) as condition, inverted: passes on failure. Fixed to !result. HW-gated.

Verified recommended fix

Source-confirmed: vega12_display_configuration_changed_task PP_ASSERT_WITH_CODE(result,...) uses result (0=success) as condition, inverted: passes on failure. Fixed to !result. HW-gated.

Verdict

Source-confirmed: vega12_display_configuration_changed_task PP_ASSERT_WITH_CODE(result,...) uses result (0=success) as condition, inverted: passes on failure. Fixed to !result. HW-gated.