β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1348

Unbounded bcopy of CDB into CmdBlock[12] overflows SRB on >12-byte CDBs

Summary

amd_action XPT_SCSI_IO at amd.c:399-400: bcopy(cdb_bytes,CmdBlock,cdb_len). CmdBlock[12] (amd.h:159). cdb_len u8 from CAM. cdb_len>12 overflows into pccb pointer. 16-byte CDB lands in padding on amd64. cdb_len>=17 corrupts pccb -> deref at :240. Sibling of DF-1235/DF-1270. Root/operator via pass(4). Fix: check cdb_len<=sizeof(CmdBlock).

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1348 Β· 2 files
FileTypeDescriptionSize
VERDICT.md verdict verification verdict 843 B ↓ raw
fix.diff suggested-fix git-apply-able fix 602 B view raw
VERDICT.md verdict verification verdict
↓ download raw

DF-1348 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: likely

Finding

Unbounded bcopy of CDB into CmdBlock[12] overflows SRB on >12-byte CDBs

Source Location

sys/dev/disk/amd/amd.c:399-400

Verdict

Source-confirmed: Unbounded bcopy of CDB into CmdBlock[12] overflows SRB on >12-byte CDB. Fix applies and compiles.

Fix Status

fixed: VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

Summary

amd_action XPT_SCSI_IO at amd.c:399-400: bcopy(cdb_bytes,CmdBlock,cdb_len). CmdBlock[12] (amd.h:159). cdb_len u8 from CAM. cdb_len>12 overflows into pccb pointer. 16-byte CDB lands in padding on amd64. cdb_len>=17 corrupts pccb -> deref at :240. Sibling of DF-1235/DF-1270. Root/operator via pass(4). Fix: check cdb_len<=sizeof(CmdBlock).

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: amd driver bcopy of pcsio->cdb_len into CmdBlock[12] without bound, OOB write for >12-byte CDBs. Added imin(cdb_len, sizeof(CmdBlock)). HW-gated.

Verified recommended fix

Source-confirmed: amd driver bcopy of pcsio->cdb_len into CmdBlock[12] without bound, OOB write for >12-byte CDBs. Added imin(cdb_len, sizeof(CmdBlock)). HW-gated.

Verdict

Source-confirmed: amd driver bcopy of pcsio->cdb_len into CmdBlock[12] without bound, OOB write for >12-byte CDBs. Added imin(cdb_len, sizeof(CmdBlock)). HW-gated.