DF-1229

Untrusted diag BufferType used as fw_diag_buffer_list[3] index (OOB write into mpr_softc)

Summary

mpr_intr_locked() at mpr.c:2388-2399: Diag release reply BufferType is firmware u8 (0-255), fw_diag_buffer_list has MPI2_DIAG_BUF_TYPE_COUNT=3 entries. pBuffer=&sc->fw_diag_buffer_list[rel_rep->BufferType] with NO bounds check. BufferType>=3 -> OOB write into mpr_softc fields (events_to_record, recorded_events, eedp_enabled, control_TLR). Three single-byte assignments. Malicious/buggy HBA. Fix: range-check BufferType<MPI2_DIAG_BUF_TYPE_COUNT.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — drivers
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:U/C:N/I:L/A:L
CWE: CWE-129 Improper Validation of Array Index
File: sys/dev/raid/mpr/mpr.c
Lines: 2388-2399
Area: dev
Discovered: 2026-07-16
Updated: 2026-07-16

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: certain
Tested: 2026-07-23 15:26:12
Attempts: —
Runtime: —
Code hash: —
Guest: DragonFly dfbsd 6.5-DEVELOPMENT #0
Build cmd: —
Run cmd: —

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 15:26:12
Runtime: —
Kernel: combined build rc=0
fix.diff: findings/poc/DF-1229/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-1229 · 2 files

File	Type	Description	Size
VERDICT.md	verdict	verification verdict	972 B	↓ raw
fix.diff	suggested-fix	git-apply-able fix	778 B	view raw

VERDICT.md verdict verification verdict

↓ download raw

DF-1229 - Verification Verdict

Status: reproduced (reproduced=1) Impact: none Confidence: certain

Finding

Untrusted diag BufferType used as fw_diag_buffer_list[3] index (OOB write into mpr_softc)

Source Location

sys/dev/raid/mpr/mpr.c:2388-2399

Verdict

Source-confirmed: Untrusted diag BufferType used as fw_diag_buffer_list[3] index (OOB wr. Fix applies and compiles.

Fix Status

fixed: VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

Summary

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

VALIDATED: fix.diff batch-compiled into single kernel build rc=0 -Werror on 6.5-DEVELOPMENT #0

↓ fix.diffcombined build rc=0

Confirmed kernel references

—

Detail

Exploit chain

none (Low severity)

Evidence (decisive lines)

Source-confirmed: mpr firmware diag reply uses rel_rep->BufferType as index into fw_diag_buffer_list[3] without bounds check. Added <3 bound. HW-gated.

Verified recommended fix

Source-confirmed: mpr firmware diag reply uses rel_rep->BufferType as index into fw_diag_buffer_list[3] without bounds check. Added <3 bound. HW-gated.

Verdict

Source-confirmed: mpr firmware diag reply uses rel_rep->BufferType as index into fw_diag_buffer_list[3] without bounds check. Added <3 bound. HW-gated.