β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1170

Divide-by-zero in smu7_get_profiling_clk when golden MCLK value is zero

Summary

smu7_get_profiling_clk at :2737-2741: divides by golden_dpm_table.mclk_table.dpm_levels[count-1].value with no zero check. Crafted PP table with MCLK level value 0 -> kernel #DE panic when user writes PROFILE_* to power_dpm_force_performance_level. Fix: check value!=0 before division.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1170 Β· 3 files
FileTypeDescriptionSize
VERDICT.md verdict Source-confirmation verdict for DF-1170 622 B ↓ raw
fix.diff suggested-fix Guard golden MCLK value==0 in smu7_get_profiling_clk 445 B view raw
../fix_build.log build-log Batch kernel build log (all fixes, rc=0) 5.6 MB ↓ download
VERDICT.md verdict Source-confirmation verdict for DF-1170
↓ download raw

DF-1170 Verification Verdict

Severity: Low Impact class: panic Verification method: Source-only confirmation (HW-gated, not triggerable on QEMU guest)

Verdict: REPRODUCED (source-confirmed)

The bug is confirmed in the audited source at the cited path:line. Triggerable but requires specific driver/config.

Fix: Guard golden MCLK value==0 in smu7_get_profiling_clk

Fix applied and validated in batch kernel build (rc=0, -Werror).

Fix validation

All 41-fix patches batched into single make -j6 nativekernel KERNCONF=X86_64_GENERIC build. Build result: rc=0, 0 errors (full -Werror clean).

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff applies cleanly + batch kernel build rc=0 -Werror; bug HW/module/runtime-gated, no runtime PoC re-test possible on guest.

VALIDATED: fix.diff applies cleanly + batch kernel build rc=0 -Werror; bug HW/module/runtime-gated, no runtime PoC re-test possible on guest.
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none

Evidence (decisive lines)

REPRODUCED (source-only): smu7_get_profiling_clk divides by golden_dpm_table.mclk_table.dpm_levels[count-1].value with no zero check; crafted PP table -> #DE panic.

Verified recommended fix

REPRODUCED (source-only): smu7_get_profiling_clk divides by golden_dpm_table.mclk_table.dpm_levels[count-1].value with no zero check; crafted PP table -> #DE panic.

Verdict

REPRODUCED (source-only): smu7_get_profiling_clk divides by golden_dpm_table.mclk_table.dpm_levels[count-1].value with no zero check; crafted PP table -> #DE panic.