β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-1140

OOB read in si_parse_power_table: nonClockInfoIndex taken from VBIOS without bounds check

Summary

si_parse_power_table at si_dpm.c:6848-6850: non_clock_array_index=power_state->v2.nonClockInfoIndex (u8 from BIOS) used to index non_clock_info_array->nonClockInfo[index] with NO check against ucNumEntries (unlike clock loop at :6866 which checks). Crafted VBIOS with index>=ucNumEntries reads past nonClockInfo array -> info leak via sysfs power_dpm_state or panic. Attacker: malicious VBIOS. Fix: add same guard as clock loop.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-1140 Β· 3 files
FileTypeDescriptionSize
VERDICT.md verdict Source-confirmation verdict for DF-1140 624 B ↓ raw
fix.diff suggested-fix Bounds-check nonClockInfoIndex against ucNumEntries 545 B view raw
../fix_build.log build-log Batch kernel build log (all fixes, rc=0) 5.6 MB ↓ download
VERDICT.md verdict Source-confirmation verdict for DF-1140
↓ download raw

DF-1140 Verification Verdict

Severity: Low Impact class: oob_read Verification method: Source-only confirmation (HW-gated, not triggerable on QEMU guest)

Verdict: REPRODUCED (source-confirmed)

The bug is confirmed in the audited source at the cited path:line. Triggerable but requires specific driver/config.

Fix: Bounds-check nonClockInfoIndex against ucNumEntries

Fix applied and validated in batch kernel build (rc=0, -Werror).

Fix validation

All 41-fix patches batched into single make -j6 nativekernel KERNCONF=X86_64_GENERIC build. Build result: rc=0, 0 errors (full -Werror clean).

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff applies cleanly + batch kernel build rc=0 -Werror; bug HW/module/runtime-gated, no runtime PoC re-test possible on guest.

VALIDATED: fix.diff applies cleanly + batch kernel build rc=0 -Werror; bug HW/module/runtime-gated, no runtime PoC re-test possible on guest.
↓ fix.diffcombined build rc=0

Confirmed kernel references

β€”

Detail

Exploit chain

none

Evidence (decisive lines)

REPRODUCED (source-only): si_parse_power_table uses nonClockInfoIndex (u8) to index non_clock_info_array->nonClockInfo[] with NO bounds check against ucNumEntries (unlike clock loop). OOB read.

Verified recommended fix

REPRODUCED (source-only): si_parse_power_table uses nonClockInfoIndex (u8) to index non_clock_info_array->nonClockInfo[] with NO bounds check against ucNumEntries (unlike clock loop). OOB read.

Verdict

REPRODUCED (source-only): si_parse_power_table uses nonClockInfoIndex (u8) to index non_clock_info_array->nonClockInfo[] with NO bounds check against ucNumEntries (unlike clock loop). OOB read.