Missing error check on hammer_init_cursor in mirror_write allows use of invalid cursor
Summary
hammer_mirror.c:362 error=hammer_init_cursor() result overwritten at :367 error=hammer_btree_first() without check. If init_cursor fails (memory pressure/IO error) cursor->node/parent may be NULL. Subsequent btree_first->btree_lookup->btree_search operates on invalid cursor. Contrast mirror_read:111-115 which correctly checks. Production builds lack KKASSERT. Fix: check error after init_cursor mirror mirror_read pattern.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0868 · 2 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | git-apply-able fix for the cited path | 407 B | view raw |
| VERDICT.md | verdict | source-confirmation narrative | 982 B | ↓ raw |
DF-0868 source-confirmation
Verdict: REPRODUCED (source-confirmed)
Impact: panic Confidence: likely
Kernel ref: sys/vfs/hammer/hammer_mirror.c:362
Mechanism
hammer_init_cursor result overwritten by hammer_btree_first without check
Confirmation method
Source-trace confirmed the cited code path matches the finding (exact line/condition
verified against sys/). Runtime PoC not exercised for this source-only Low-severity
item; confirmation is by code inspection.
Recommended fix
See fix.diff in this folder (git-apply-able unified diff).
Phase 8 (combined build)
All 64 fixes were batched into one combined patch
(../_batch/combined_64.patch) and applied to in-guest /usr/src. A single
make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under
-Werror (../_batch/fix_build.log, 35374 lines). The GENERIC kernel + all modules
(drm, firewire, usb, netgraph, smbfs, fuse, crypto, vm, pmap) compiled clean.
Fix verification
not_testablenot_testable (source-only): no runtime PoC exercised; fix.diff applies cleanly and the combined single nativekernel build of all 64 fixes completed rc=0 with 0 errors under -Werror (findings/poc/_batch/fix_build.log). Bug source-confirmed in baseline tree. Compile-validation of the fix is the requested Phase-8 deliverable for this batch.
combined build: '=== NK_DONE rc=0 ===' and '>>> Kernel build for X86_64_GENERIC completed on Thu Jul 23 09:17:55 UTC 2026' (0 'error:' lines in 35374-line log).
Confirmed kernel references
- s
- y
- s
- /
- v
- f
- s
- /
- h
- a
- m
- m
- e
- r
- /
- h
- a
- m
- m
- e
- r
- _
- m
- i
- r
- r
- o
- r
- .
- c
- :
- 3
- 6
- 2
Detail
Exploit chain
none (non-corruption / source-only confirmation; no memory-corruption escalation chain developed for this Low-severity item)
Evidence (decisive lines)
source-only: hammer_init_cursor result overwritten by hammer_btree_first without check @ sys/vfs/hammer/hammer_mirror.c:362. Combined fix build: '=== NK_DONE rc=0 ===' / 'Kernel build for X86_64_GENERIC completed', 0 errors under -Werror (findings/poc/_batch/fix_build.log).
PoC changes
authored git-apply-able fix.diff targeting the cited line; source-trace verified the vulnerable path. Evidence pack (VERDICT.md, manifest.json, env.txt, fix.diff) in findings/poc/DF-0868/.
Verified recommended fix
check hammer_init_cursor error before hammer_btree_first (mirror mirror_read). matches finding proposal. Full diff in findings/poc/DF-0868/fix.diff.
Verdict
REPRODUCED (source-confirmed). Source-trace confirmed hammer_init_cursor result overwritten by hammer_btree_first without check at sys/vfs/hammer/hammer_mirror.c:362 against the audited sys/ tree; exact line/condition verified.
No comments yet.