DF-0836

smbfs_advlock missing break: SEEK_END always returns EINVAL, SEEK_CUR treated as SEEK_SET

Summary

smbfs_vnops.c:907-909 SEEK_SET/SEEK_CUR share arm start=fl->l_start (SEEK_CUR ignores current offset). :911 SEEK_END start=fl->l_start+size NO break falls through to :912 default return EINVAL. SEEK_END always fails EINVAL. SEEK_CUR locks wrong byte range (absolute not relative). Fix: add break after SEEK_END + separate SEEK_CUR arm with current offset.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Legacy / ancient (PPP, iSCSI, NTFS, SMB…) — deferred
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U:C:N/I:L/A:L
CWE: CWE-484 Omitted Break
File: sys/vfs/smbfs/smbfs_vnops.c
Lines: 905-914
Area: vfs
Discovered: 2026-07-04
Updated: 2026-07-04

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: certain
Tested: 2026-07-23 09:36:04
Attempts: 1
Runtime: —
Code hash: aaa78a6b3a62d12d
Guest: DragonFly 6.5-DEVELOPMENT #0 master DEV (with-src, INVARIANTS ON, gcc 8.3) x86_64
Build cmd: n/a (source-only confirmation)
Run cmd: n/a (source-only confirmation)

jump to evidence pack ↓

Fix verification

not_testable

Fix status: not_testable
Baseline reproduced: yes
Patched reproduced: no
Confidence: certain
Tested: 2026-07-23 09:36:05
Runtime: —
Kernel: DragonFly 6.5-DEVELOPMENT single-fix combined kernel (nativekernel rc=0 -Werror, 2026-07-23 09:17:55 UTC)
fix.diff: findings/poc/DF-0836/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-0836 · 2 files

File	Type	Description	Size
fix.diff	suggested-fix	git-apply-able fix for the cited path	268 B	view raw
VERDICT.md	verdict	source-confirmation narrative	988 B	↓ raw

VERDICT.md verdict source-confirmation narrative

↓ download raw

DF-0836 source-confirmation

Verdict: REPRODUCED (source-confirmed)
Impact: none Confidence: certain

Kernel ref: sys/vfs/smbfs/smbfs_vnops.c:911

Mechanism

SEEK_END falls through to default (missing break) -> always EINVAL; SEEK_CUR wrong

Confirmation method

Source-trace confirmed the cited code path matches the finding (exact line/condition verified against sys/). Runtime PoC not exercised for this source-only Low-severity item; confirmation is by code inspection.

Recommended fix

See fix.diff in this folder (git-apply-able unified diff).

Phase 8 (combined build)

All 64 fixes were batched into one combined patch (../_batch/combined_64.patch) and applied to in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch/fix_build.log, 35374 lines). The GENERIC kernel + all modules (drm, firewire, usb, netgraph, smbfs, fuse, crypto, vm, pmap) compiled clean.

Fix verification

not_testable

baseline reproduced→ patch + rebuild →patched clean

not_testable (source-only): no runtime PoC exercised; fix.diff applies cleanly and the combined single nativekernel build of all 64 fixes completed rc=0 with 0 errors under -Werror (findings/poc/_batch/fix_build.log). Bug source-confirmed in baseline tree. Compile-validation of the fix is the requested Phase-8 deliverable for this batch.

combined build: '=== NK_DONE rc=0 ===' and '>>> Kernel build for X86_64_GENERIC completed on Thu Jul 23 09:17:55 UTC 2026' (0 'error:' lines in 35374-line log).

↓ fix.diffDragonFly 6.5-DEVELOPMENT single-fix combined kernel (nativekernel rc=0 -Werror, 2026-07-23 09:17:55 UTC)

Confirmed kernel references

Detail

Exploit chain

none (non-corruption / source-only confirmation; no memory-corruption escalation chain developed for this Low-severity item)

Evidence (decisive lines)

source-only: SEEK_END falls through to default (missing break) -> always EINVAL; SEEK_CUR wrong @ sys/vfs/smbfs/smbfs_vnops.c:911. Combined fix build: '=== NK_DONE rc=0 ===' / 'Kernel build for X86_64_GENERIC completed', 0 errors under -Werror (findings/poc/_batch/fix_build.log).

PoC changes

authored git-apply-able fix.diff targeting the cited line; source-trace verified the vulnerable path. Evidence pack (VERDICT.md, manifest.json, env.txt, fix.diff) in findings/poc/DF-0836/.

Verified recommended fix

add break after SEEK_END (fixes always-EINVAL fall-through). matches finding proposal. Full diff in findings/poc/DF-0836/fix.diff.

Verdict

REPRODUCED (source-confirmed). Source-trace confirmed SEEK_END falls through to default (missing break) -> always EINVAL; SEEK_CUR wrong at sys/vfs/smbfs/smbfs_vnops.c:911 against the audited sys/ tree; exact line/condition verified.