dirfs_getattr returns 0 unconditionally even when dirfs_node_stat fails — stale/uninitialized attributes
Summary
dirfs_vnops.c:368-425 error=dirfs_node_stat(...). :399 if(error==0) fill vap. :424 return 0 — ALWAYS returns success even when stat failed. Caller told operation succeeded but vattr fields never populated from fresh stat. VATTR_NULL callers get VNOVAL stale fields. Race unlink vs stat: stat() returns success with stale attrs for non-existent file. Contract violation. Fix: return error.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0809 · 2 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | git-apply-able fix for the cited path | 241 B | view raw |
| VERDICT.md | verdict | source-confirmation narrative | 969 B | ↓ raw |
DF-0809 source-confirmation
Verdict: REPRODUCED (source-confirmed)
Impact: none Confidence: certain
Kernel ref: sys/vfs/dirfs/dirfs_vnops.c:424
Mechanism
dirfs_getattr returns 0 unconditionally even when stat() failed
Confirmation method
Source-trace confirmed the cited code path matches the finding (exact line/condition
verified against sys/). Runtime PoC not exercised for this source-only Low-severity
item; confirmation is by code inspection.
Recommended fix
See fix.diff in this folder (git-apply-able unified diff).
Phase 8 (combined build)
All 64 fixes were batched into one combined patch
(../_batch/combined_64.patch) and applied to in-guest /usr/src. A single
make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under
-Werror (../_batch/fix_build.log, 35374 lines). The GENERIC kernel + all modules
(drm, firewire, usb, netgraph, smbfs, fuse, crypto, vm, pmap) compiled clean.
Fix verification
not_testablenot_testable (source-only): no runtime PoC exercised; fix.diff applies cleanly and the combined single nativekernel build of all 64 fixes completed rc=0 with 0 errors under -Werror (findings/poc/_batch/fix_build.log). Bug source-confirmed in baseline tree. Compile-validation of the fix is the requested Phase-8 deliverable for this batch.
combined build: '=== NK_DONE rc=0 ===' and '>>> Kernel build for X86_64_GENERIC completed on Thu Jul 23 09:17:55 UTC 2026' (0 'error:' lines in 35374-line log).
Confirmed kernel references
- s
- y
- s
- /
- v
- f
- s
- /
- d
- i
- r
- f
- s
- /
- d
- i
- r
- f
- s
- _
- v
- n
- o
- p
- s
- .
- c
- :
- 4
- 2
- 4
Detail
Exploit chain
none (non-corruption / source-only confirmation; no memory-corruption escalation chain developed for this Low-severity item)
Evidence (decisive lines)
source-only: dirfs_getattr returns 0 unconditionally even when stat() failed @ sys/vfs/dirfs/dirfs_vnops.c:424. Combined fix build: '=== NK_DONE rc=0 ===' / 'Kernel build for X86_64_GENERIC completed', 0 errors under -Werror (findings/poc/_batch/fix_build.log).
PoC changes
authored git-apply-able fix.diff targeting the cited line; source-trace verified the vulnerable path. Evidence pack (VERDICT.md, manifest.json, env.txt, fix.diff) in findings/poc/DF-0809/.
Verified recommended fix
return error (not 0) from dirfs_getattr. matches finding proposal. Full diff in findings/poc/DF-0809/fix.diff.
Verdict
REPRODUCED (source-confirmed). Source-trace confirmed dirfs_getattr returns 0 unconditionally even when stat() failed at sys/vfs/dirfs/dirfs_vnops.c:424 against the audited sys/ tree; exact line/condition verified.
No comments yet.