Build break: IFP2SP and SP2IFP macros referenced 12 times but never defined anywhere in sys/
Summary
IFP2SP() and SP2IFP() used at ng_sppp.c:254,273,280,282,322,335,360,366,372,375,378,381 but NEVER #defined anywhere in sys/ (rg confirmed zero matches for define IFP2SP / define SP2IFP). Historical FreeBSD ng_sppp.c had these in if_sppp.h DragonFly import dropped them. File fails to compile — effectively dead code. sys/conf/files:1728 optional netgraph7_sppp not in any default kernel config. Makes DF-0720 (heap overflow) and DF-0722 (bitmap truncation) latent. Fix: add #define IFP2SP(ifp) ((struct sppp*)(ifp)) #define SP2IFP(sp) (&(sp)->pp_if) to if_sppp.h.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0721 · 1 files| File | Type | Description | Size | |
|---|---|---|---|---|
| manifest.json | file | 389 B | view raw |
Fix verification
not_testablerecommended fix identified; fix.diff not authored/validated in this batch
recommended fix identified; fix.diff not authored/validated in this batch
Confirmed kernel references
—
Detail
Exploit chain
none (Info severity)
Evidence (decisive lines)
Source-confirmed at sys/netgraph7/ng_sppp.c:254: build break - IFP2SP/SP2IFP macros never defined (dead code)
Verified recommended fix
Source-confirmed at sys/netgraph7/ng_sppp.c:254: build break - IFP2SP/SP2IFP macros never defined (dead code)
Verdict
Source-confirmed at sys/netgraph7/ng_sppp.c:254: build break - IFP2SP/SP2IFP macros never defined (dead code)
No comments yet.