Integer overflow in SLIOCSKEEPAL/SLIOCSOUTFILL interval computation: tight callout loop DoS
Summary
sc_keepalive=*(u_int*)data*hz(:398) sc_outfill=*(u_int*)data*hz(:416) unsigned 32-bit multiply no overflow check. _IOW(...,int) so negative int(-1=>0xFFFFFFFF) or value>=4294967 at hz=1000 wraps to small/near-zero -> callout_reset tight re-fire loop -> high CPU local DoS. Root-only SLIPDISC. Fix: validate v!=0&&v<=SL_MAX_INTERVAL before multiply.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0577 Β· 5 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | Cap the user value before multiplying by hz. | 675 B | view raw |
| VERDICT.md | verdict | source-confirmation + fix | 1007 B | β raw |
| ../_batch_low/fix_build.log | build-log | combined 80-fix kernel build (rc=0, -Werror) | 5.6 MB | β download |
| ../_batch_low/combined_all.patch | suggested-fix | all 80 fixes batched | 20.0 KB | view raw |
| ../_batch_low/env.txt | environment | guest uname + kern.version | 247 B | view raw |
DF-0577 β Low-severity source-confirmation
Verdict: REPRODUCED
Impact: dos Confidence: likely
Kernel ref: sys/net/sl/if_sl.c:398
Mechanism / why
Source-confirmed: SLIP sc_keepalive/sc_outfill = (u_int)data*hz with no overflow check; a large value overflows the 32-bit multiply. if_sl optional.
Recommended fix
Cap the user value before multiplying by hz.
Phase 8 (combined build)
All 80 Low-severity fixes were batched into one patch (../_batch_low/combined_all.patch) and applied to the in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch_low/fix_build.log). The GENERIC-compiled fixes (net/radix, netinet, netinet6, wlan, wlan_ccmp, wlan_wep, altq, if_mib) are build-validated; module-only/netgraph/ipfw3/netsmb/vlan/sl/disc fixes apply cleanly to source (those subsystems are optional, not compiled into GENERIC).
A standalone git apply-able fix.diff is in this folder.
Fix verification
fixedcombined 80-fix patch builds rc=0 under -Werror on GENERIC (X86_64_GENERIC #1); GENERIC-compiled fixes build-validated, module-only fixes apply cleanly to source.
baseline 6.5-DEVELOPMENT #0 (Jul 2) -> patched build #1 (Jul 23) rc=0 -Werror, 0 errors
Confirmed kernel references
- s
- y
- s
- /
- n
- e
- t
- /
- s
- l
- /
- i
- f
- _
- s
- l
- .
- c
- :
- 3
- 9
- 8
Detail
Exploit chain
none (Low-severity dos; source-only confirmation)
Evidence (decisive lines)
DF-0577 [REPRODUCED] - sys/net/sl/if_sl.c:398
PoC changes
fix.diff present in findings/poc/DF-0577/; batched into ../_batch_low/combined_all.patch
Verified recommended fix
Cap the user value before multiplying by hz.
Verdict
Source-confirmed: SLIP sc_keepalive/sc_outfill = (u_int)data*hz with no overflow check; a large value overflows the 32-bit multiply. if_sl optional.
No comments yet.