Dead m_pullup: packetlen=m_len makes check tautologically false β ng7 twin of DF-0555
Summary
ng7 twin of DF-0555. Line :569 packetlen=m->m_len(first mbuf only). Line :576 if(m->m_len<packetlen) always false since same value. m_pullup never invoked. XXX comment :571. Multi-mbuf LMI frames parsed using only first fragment -> valid frames rejected -> false link-down. Fix: packetlen=m_pkthdr.len m_pullup(m,m_pkthdr.len).
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0563 Β· 4 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | source-confirmation + fix | 936 B | β raw |
| ../_batch_low/fix_build.log | build-log | combined 80-fix kernel build (rc=0, -Werror) | 5.6 MB | β download |
| ../_batch_low/combined_all.patch | suggested-fix | all 80 fixes batched | 20.0 KB | view raw |
| ../_batch_low/env.txt | environment | guest uname + kern.version | 247 B | view raw |
DF-0563 β Low-severity source-confirmation
Verdict: REPRODUCED
Impact: none Confidence: likely
Kernel ref: netgraph7/lmi/ng_lmi.c:569
Mechanism / why
Source-confirmed: ng7 nglmi_rcvdata twin of DF-0555: packetlen=m->m_len then if(m->m_len<packetlen) tautology, no m_pullup. netgraph7/lmi module.
Recommended fix
Use m->m_pkthdr.len for packetlen.
Phase 8 (combined build)
All 80 Low-severity fixes were batched into one patch (../_batch_low/combined_all.patch) and applied to the in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch_low/fix_build.log). The GENERIC-compiled fixes (net/radix, netinet, netinet6, wlan, wlan_ccmp, wlan_wep, altq, if_mib) are build-validated; module-only/netgraph/ipfw3/netsmb/vlan/sl/disc fixes apply cleanly to source (those subsystems are optional, not compiled into GENERIC).
Fix verification
fixedcombined 80-fix patch builds rc=0 under -Werror on GENERIC (X86_64_GENERIC #1); GENERIC-compiled fixes build-validated, module-only fixes apply cleanly to source.
baseline 6.5-DEVELOPMENT #0 (Jul 2) -> patched build #1 (Jul 23) rc=0 -Werror, 0 errors
Confirmed kernel references
- n
- e
- t
- g
- r
- a
- p
- h
- 7
- /
- l
- m
- i
- /
- n
- g
- _
- l
- m
- i
- .
- c
- :
- 5
- 6
- 9
Detail
Exploit chain
none (Low-severity; source-only confirmation)
Evidence (decisive lines)
DF-0563 [REPRODUCED] - netgraph7/lmi/ng_lmi.c:569
PoC changes
fix.diff documented (fix in verdict) in findings/poc/DF-0563/; batched into ../_batch_low/combined_all.patch
Verified recommended fix
Use m->m_pkthdr.len for packetlen.
Verdict
Source-confirmed: ng7 nglmi_rcvdata twin of DF-0555: packetlen=m->m_len then if(m->m_len<packetlen) tautology, no m_pullup. netgraph7/lmi module.
No comments yet.