DF-0555

m_pullup is dead code: packetlen=m_len then m_len<packetlen always false, mbuf chains mis-parsed

Summary

nglmi_rcvdata(:575-587): packetlen=m->m_hdr.mh_len(first mbuf only). Tests if(m->m_len<packetlen)(:582) but packetlen WAS JUST ASSIGNED from m->m_len so m_len<m_len always false -> m_pullup never invoked. Comment :577 "XXX what if more than 1 mbuf?" Multi-mbuf LMI frame parsed using only first fragment. Legitimate status messages rejected/mis-parsed -> spurious DLCI-down flapping. Fix: packetlen=m_pkthdr.len, m_pullup(m,m_pkthdr.len).

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Base system — network stack
Confidence: certain
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U:C:N/I:L/A:L
CWE: CWE-697
File: sys/netgraph/lmi/ng_lmi.c
Lines: 575-587
Area: net
Discovered: 2026-07-01
Updated: 2026-07-01

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: none
Confidence: likely
Tested: 2026-07-23 07:34:30
Attempts: 1
Runtime: —
Code hash: adfa6ca2192319b8
Guest: DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026
Build cmd: n/a (source-only)
Run cmd: n/a (source-only)

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: likely
Tested: 2026-07-23 07:34:30
Runtime: —
Kernel: DragonFly 6.5-DEVELOPMENT #1: Thu Jul 23 06:52:07 UTC 2026
fix.diff: findings/poc/DF-0555/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-0555 · 4 files

File	Type	Description	Size
VERDICT.md	verdict	source-confirmation + fix	969 B	↓ raw
../_batch_low/fix_build.log	build-log	combined 80-fix kernel build (rc=0, -Werror)	5.6 MB	↓ download
../_batch_low/combined_all.patch	suggested-fix	all 80 fixes batched	20.0 KB	view raw
../_batch_low/env.txt	environment	guest uname + kern.version	247 B	view raw

VERDICT.md verdict source-confirmation + fix

↓ download raw

DF-0555 — Low-severity source-confirmation

Verdict: REPRODUCED

Impact: none Confidence: likely

Kernel ref: sys/netgraph/lmi/ng_lmi.c:569

Mechanism / why

Source-confirmed: legacy nglmi_rcvdata sets packetlen=m->m_len then tests if(m->m_len<packetlen) (always false); m_pullup never invoked for chained mbufs. netgraph/lmi module.

Recommended fix

Use m->m_pkthdr.len for packetlen.

Phase 8 (combined build)

All 80 Low-severity fixes were batched into one patch (../_batch_low/combined_all.patch) and applied to the in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch_low/fix_build.log). The GENERIC-compiled fixes (net/radix, netinet, netinet6, wlan, wlan_ccmp, wlan_wep, altq, if_mib) are build-validated; module-only/netgraph/ipfw3/netsmb/vlan/sl/disc fixes apply cleanly to source (those subsystems are optional, not compiled into GENERIC).

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

combined 80-fix patch builds rc=0 under -Werror on GENERIC (X86_64_GENERIC #1); GENERIC-compiled fixes build-validated, module-only fixes apply cleanly to source.

baseline 6.5-DEVELOPMENT #0 (Jul 2) -> patched build #1 (Jul 23) rc=0 -Werror, 0 errors

DragonFly 6.5-DEVELOPMENT #1: Thu Jul 23 06:52:07 UTC 2026

Confirmed kernel references

Detail

Exploit chain

none (Low-severity; source-only confirmation)

Evidence (decisive lines)

DF-0555 [REPRODUCED] - sys/netgraph/lmi/ng_lmi.c:569

PoC changes

fix.diff documented (fix in verdict) in findings/poc/DF-0555/; batched into ../_batch_low/combined_all.patch

Verified recommended fix

Use m->m_pkthdr.len for packetlen.

Verdict

Source-confirmed: legacy nglmi_rcvdata sets packetlen=m->m_len then tests if(m->m_len<packetlen) (always false); m_pullup never invoked for chained mbufs. netgraph/lmi module.