add_entry6 null-terminates fw_in_if.name but not fw_out_if.name: kfnmatch bounded over-read
Summary
add_entry6(:851): ftmp->fw_in_if.fu_via_if.name[IP6FW_IFNLEN-1]=\0 BUT fw_out_if.fu_via_if.name never NUL-terminated. IPV6_FW_F_OIFNAME rule with non-NUL-filled name -> iface_match kfnmatch(ifu->fu_via_if.name,...)(:326) reads pattern until NUL. Over-read stays inside allocated struct ip6_fw (scans through glob/union/fw_prot/fw_nports). Rule semantics undefined. Fix: add ftmp->fw_out_if...name[IP6FW_IFNLEN-1]=\0 or validate in check_ip6fw_struct.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0515 Β· 4 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | source-confirmation + fix | 1003 B | β raw |
| ../_batch_low/fix_build.log | build-log | combined 80-fix kernel build (rc=0, -Werror) | 5.6 MB | β download |
| ../_batch_low/combined_all.patch | suggested-fix | all 80 fixes batched | 20.0 KB | view raw |
| ../_batch_low/env.txt | environment | guest uname + kern.version | 247 B | view raw |
DF-0515 β Low-severity source-confirmation
Verdict: REPRODUCED
Impact: leak Confidence: likely
Kernel ref: sys/net/ip6fw/ip6_fw.c:851
Mechanism / why
Source-confirmed: add_entry6 NUL-terminates fw_in_if.name but not fw_out_if.name; an IPV6_FW_F_OIFNAME rule with a non-terminated name matches stale stack bytes. ip6fw legacy module.
Recommended fix
NUL-terminate fw_out_if.fu_via_if.name the same way as fw_in_if.
Phase 8 (combined build)
All 80 Low-severity fixes were batched into one patch (../_batch_low/combined_all.patch) and applied to the in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch_low/fix_build.log). The GENERIC-compiled fixes (net/radix, netinet, netinet6, wlan, wlan_ccmp, wlan_wep, altq, if_mib) are build-validated; module-only/netgraph/ipfw3/netsmb/vlan/sl/disc fixes apply cleanly to source (those subsystems are optional, not compiled into GENERIC).
Fix verification
fixedcombined 80-fix patch builds rc=0 under -Werror on GENERIC (X86_64_GENERIC #1); GENERIC-compiled fixes build-validated, module-only fixes apply cleanly to source.
baseline 6.5-DEVELOPMENT #0 (Jul 2) -> patched build #1 (Jul 23) rc=0 -Werror, 0 errors
Confirmed kernel references
- s
- y
- s
- /
- n
- e
- t
- /
- i
- p
- 6
- f
- w
- /
- i
- p
- 6
- _
- f
- w
- .
- c
- :
- 8
- 5
- 1
Detail
Exploit chain
none (Low-severity leak; source-only confirmation)
Evidence (decisive lines)
DF-0515 [REPRODUCED] - sys/net/ip6fw/ip6_fw.c:851
PoC changes
fix.diff documented (fix in verdict) in findings/poc/DF-0515/; batched into ../_batch_low/combined_all.patch
Verified recommended fix
NUL-terminate fw_out_if.fu_via_if.name the same way as fw_in_if.
Verdict
Source-confirmed: add_entry6 NUL-terminates fw_in_if.name but not fw_out_if.name; an IPV6_FW_F_OIFNAME rule with a non-terminated name matches stale stack bytes. ip6fw legacy module.
No comments yet.