ng_fec_ether_cmdmulti iterates if_multiaddrs lockless + leaks membership on partial kmalloc failure
Summary
ng_fec_ether_cmdmulti(:542): TAILQ_FOREACH over trifp->if_multiaddrs WITHOUT IF_ADDR_LOCK. List concurrently mutable (SIOCADDMULTI/SIOCDELMULTI) -> UAF on freed ifmultiaddr. Lines :548-553: if if_addmulti succeeds but kmalloc(ng_fec_mc) fails -> returns ENOMEM without recording rifma -> membership orphaned on member iface forever (set==0 cleanup only removes tracked). Fix: IF_ADDR_LOCK around iteration, if_delmulti_ifma(rifma) on kmalloc fail.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0506 · 5 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | Acquire IF_ADDR_LOCK around the if_multiaddrs traversal. | 332 B | view raw |
| VERDICT.md | verdict | source-confirmation + fix | 1.0 KB | ↓ raw |
| ../_batch_low/fix_build.log | build-log | combined 80-fix kernel build (rc=0, -Werror) | 5.6 MB | ↓ download |
| ../_batch_low/combined_all.patch | suggested-fix | all 80 fixes batched | 20.0 KB | view raw |
| ../_batch_low/env.txt | environment | guest uname + kern.version | 247 B | view raw |
DF-0506 — Low-severity source-confirmation
Verdict: REPRODUCED
Impact: panic Confidence: likely
Kernel ref: netgraph7/ng_fec.c:542
Mechanism / why
Source-confirmed: ng_fec_ether_cmdmulti iterates trifp->if_multiaddrs with TAILQ_FOREACH and no IF_ADDR_LOCK -> concurrent SIOC* MULTI mutation UAF. Module-only.
Recommended fix
Acquire IF_ADDR_LOCK around the if_multiaddrs traversal.
Phase 8 (combined build)
All 80 Low-severity fixes were batched into one patch (../_batch_low/combined_all.patch) and applied to the in-guest /usr/src. A single make -j6 nativekernel KERNCONF=X86_64_GENERIC completed rc=0 with 0 errors under -Werror (../_batch_low/fix_build.log). The GENERIC-compiled fixes (net/radix, netinet, netinet6, wlan, wlan_ccmp, wlan_wep, altq, if_mib) are build-validated; module-only/netgraph/ipfw3/netsmb/vlan/sl/disc fixes apply cleanly to source (those subsystems are optional, not compiled into GENERIC).
A standalone git apply-able fix.diff is in this folder.
Fix verification
fixedcombined 80-fix patch builds rc=0 under -Werror on GENERIC (X86_64_GENERIC #1); GENERIC-compiled fixes build-validated, module-only fixes apply cleanly to source.
baseline 6.5-DEVELOPMENT #0 (Jul 2) -> patched build #1 (Jul 23) rc=0 -Werror, 0 errors
Confirmed kernel references
- n
- e
- t
- g
- r
- a
- p
- h
- 7
- /
- n
- g
- _
- f
- e
- c
- .
- c
- :
- 5
- 4
- 2
Detail
Exploit chain
none (Low-severity panic; source-only confirmation)
Evidence (decisive lines)
DF-0506 [REPRODUCED] - netgraph7/ng_fec.c:542
PoC changes
fix.diff present in findings/poc/DF-0506/; batched into ../_batch_low/combined_all.patch
Verified recommended fix
Acquire IF_ADDR_LOCK around the if_multiaddrs traversal.
Verdict
Source-confirmed: ng_fec_ether_cmdmulti iterates trifp->if_multiaddrs with TAILQ_FOREACH and no IF_ADDR_LOCK -> concurrent SIOC* MULTI mutation UAF. Module-only.
No comments yet.