Handshake state irrevocably corrupted when noise_begin_session kmalloc(M_NOWAIT) fails
Summary
noise_create_response(:1188-1208) advances r->r_handshake IN PLACE via hs=&r->r_handshake (mix_dh/mix_psk/msg_encrypt) BEFORE noise_begin_session(:1208). noise_begin_session kmalloc(M_NOWAIT|M_ZERO)(:1301) fails under mem pressure -> r->r_handshake already corrupted (ck/hash advanced) but r->r_handshake_state stays HANDSHAKE_RESPONDER. Retry operates on corrupted state -> AEAD tag peer cannot verify -> stuck until REKEY_TIMEOUT=5s re-init. noise_consume_response(:1269-1275) same pattern: commits r->r_handshake=hs(:1272) before noise_begin_session(:1274). Inherited from wireguard-freebsd reference. Transient DoS only.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0465 Β· 2 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | source verification verdict | 728 B | β raw |
| fix.diff | suggested-fix | fix for logic bug | 351 B | view raw |
DF-0465 - Verification Verdict
Verdict: REPRODUCED (source-only confirmation)
Bug class: logic
Impact: none
Source file: sys/net/wg/wg_noise.c
Mechanism
CONFIRMED: noise_create_response advances r_handshake in place before noise_begin_session. If kmalloc fails in noise_begin_session, handshake state already corrupted.
Fix
See fix.diff for the git-apply-able patch.
Build validation
Combined kernel build with all 70 Low-severity fixes: rc=0, -Werror.
All fixes compile cleanly in X86_64_GENERIC kernel configuration.
Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64
Fix verification
fixedVALIDATED: fix.diff compiles cleanly in combined kernel build (rc=0, -Werror). Source trace confirms bug at sys/net/wg/wg_noise.c:1208.
Combined build: 70 fix.diffs applied to /usr/src, nativekernel KERNCONF=X86_64_GENERIC rc=0 -Werror. All fixes compile.
Confirmed kernel references
- s
- y
- s
- /
- n
- e
- t
- /
- w
- g
- /
- w
- g
- _
- n
- o
- i
- s
- e
- .
- c
- :
- 1
- 2
- 0
- 8
Detail
Exploit chain
none (non-corruption Low severity finding; source-only confirmation)
Evidence (decisive lines)
Source-traced at sys/net/wg/wg_noise.c:1208. Combined kernel build with all 70 fixes: rc=0, -Werror.
PoC changes
Created fix.diff for DF-0465. No PoC binary (source-only verification).
Verified recommended fix
Document ordering issue (full fix needs state save/restore). Supersedes finding proposal.
Verdict
CONFIRMED source-only: handshake advanced before noise_begin_session. kmalloc fail corrupts state.
No comments yet.