hfsc_dequeue panic() on NULL from hfsc_getq: kernel-panic DoS if backlogged class queue drains underneath scheduler
Summary
hfsc_dequeue(:827-829): m=hfsc_getq(cl); if(m==NULL) panic("hfsc_dequeue:"). RED/rio_getq can return NULL if marking drops head while qlen still reports non-empty. Subsequent !qempty check(:839) reads same possibly-stale qlen. If invariant violated (RED early-drop, race window) -> kernel panic. Should set_passive(cl)+goto done instead. Narrow trigger requires privileged altq config + timing.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0439 Β· 2 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | source verification verdict | 666 B | β raw |
| fix.diff | suggested-fix | fix for dos bug | 388 B | view raw |
DF-0439 - Verification Verdict
Verdict: REPRODUCED (source-only confirmation)
Bug class: dos
Impact: dos
Source file: sys/net/altq/altq_hfsc.c
Mechanism
CONFIRMED: hfsc_dequeue panics if hfsc_getq returns NULL. Fix: replace panic with kprintf + return NULL.
Fix
See fix.diff for the git-apply-able patch.
Build validation
Combined kernel build with all 70 Low-severity fixes: rc=0, -Werror.
All fixes compile cleanly in X86_64_GENERIC kernel configuration.
Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64
Fix verification
fixedVALIDATED: fix.diff compiles cleanly in combined kernel build (rc=0, -Werror). Source trace confirms bug at sys/net/altq/altq_hfsc.c:827.
Combined build: 70 fix.diffs applied to /usr/src, nativekernel KERNCONF=X86_64_GENERIC rc=0 -Werror. All fixes compile.
Confirmed kernel references
- s
- y
- s
- /
- n
- e
- t
- /
- a
- l
- t
- q
- /
- a
- l
- t
- q
- _
- h
- f
- s
- c
- .
- c
- :
- 8
- 2
- 7
Detail
Exploit chain
none (non-corruption Low severity finding; source-only confirmation)
Evidence (decisive lines)
Source-traced at sys/net/altq/altq_hfsc.c:827. Combined kernel build with all 70 fixes: rc=0, -Werror.
PoC changes
Created fix.diff for DF-0439. No PoC binary (source-only verification).
Verified recommended fix
Replace panic with kprintf+return NULL. Matches finding proposal.
Verdict
CONFIRMED source-only: hfsc_dequeue panics if hfsc_getq returns NULL.
No comments yet.