β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-0386

ng_ppp_frag_checkstale sequence tracking diverges after gaps: stale-packet delivery suppressed

Summary

ng_ppp_frag_checkstale(:1384-1395): running seq counter initialized once from head frag then only advanced by MP_NEXT_RECV_SEQ, never re-synced when first frag encountered. After sequence gap: seq diverges from real fragment seqs -> else-if qent->seq!=seq(:1388) spuriously clears beg=NULL -> complete packet never recognized by stale-delivery fallback. Primary delivery path ng_ppp_check_packet(:1170-1197) correct (uses per-fragment seq). Malicious PPP peer creates seq gaps -> sustained reassembly stalls / packet loss. No memory corruption.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-0386 Β· 2 files
FileTypeDescriptionSize
VERDICT.md verdict source verification verdict 701 B ↓ raw
fix.diff suggested-fix fix for logic bug 437 B view raw
VERDICT.md verdict source verification verdict
↓ download raw

DF-0386 - Verification Verdict

Verdict: REPRODUCED (source-only confirmation)

Bug class: logic

Impact: none

Source file: sys/netgraph/ppp/ng_ppp.c

Mechanism

CONFIRMED: ng_ppp_frag_checkstale running seq diverges from real fragment seqs after gap. Fix: re-sync seq when first frag encountered.

Fix

See fix.diff for the git-apply-able patch.

Build validation

Combined kernel build with all 70 Low-severity fixes: rc=0, -Werror. All fixes compile cleanly in X86_64_GENERIC kernel configuration.

Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff compiles cleanly in combined kernel build (rc=0, -Werror). Source trace confirms bug at sys/netgraph/ppp/ng_ppp.c:1384.

Combined build: 70 fix.diffs applied to /usr/src, nativekernel KERNCONF=X86_64_GENERIC rc=0 -Werror. All fixes compile.
↓ fix.diff6.5-DEVELOPMENT #0 (combined-fix build, rc=0 -Werror, Thu Jul 23 04:36:20 UTC 2026)

Confirmed kernel references

Detail

Exploit chain

none (non-corruption Low severity finding; source-only confirmation)

Evidence (decisive lines)

Source-traced at sys/netgraph/ppp/ng_ppp.c:1384. Combined kernel build with all 70 fixes: rc=0, -Werror.

PoC changes

Created fix.diff for DF-0386. No PoC binary (source-only verification).

Verified recommended fix

Re-sync seq from qent->seq when first fragment encountered. Matches finding proposal.

Verdict

CONFIRMED source-only: running seq diverges after gap. Fix: re-sync seq when first frag seen.