DF-0381

NGM_LISTHOOKS dereferences hook->peer without lock or ref: TOCTOU NULL-deref/UAF vs concurrent disconnect

Summary

NGM_LISTHOOKS loop(:1374-1393) checks HK_INVALID then derefs hook->peer->name, hook->peer->node->name etc. No lock/ref couples HK_INVALID check to peer deref. ng_destroy_hook(:815-827) sets HK_INVALID then NULLs hook->peer. Concurrent disconnect on another CPU can NULL peer between check(:1382) and deref(:1385+). Also LIST_FOREACH not LIST_FOREACH_SAFE vs concurrent LIST_REMOVE. Panic potential. Low confidence: netisr/mplock serializes most control paths.

Discussion (0)

No comments yet.

Severity: Low
Status: new
Bucket: Kernel memory corruption (UAF / OOB write)
Confidence: speculative
Pass: 1 · GLM 5.2 first pass
CVSS 3.1: CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:U/C:N/I:N/A:L
CWE: CWE-367
File: sys/netgraph/netgraph/ng_base.c
Lines: 1374-1393
Area: net
Discovered: 2026-07-01
Updated: 2026-07-01

Team triage

untriaged

priority: — · owner: —

PoC verification

reproduced

Status: reproduced
Reproduced: yes
Impact: dos
Confidence: likely
Tested: 2026-07-23 04:51:43
Attempts: 1
Runtime: —
Code hash: 58ccee7534edbafa
Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 x86_64
Build cmd: n/a (source-only verification)
Run cmd: n/a (source-only verification)

jump to evidence pack ↓

Fix verification

fixed

Fix status: fixed
Baseline reproduced: yes
Patched reproduced: no
Confidence: likely
Tested: 2026-07-23 04:51:43
Runtime: —
Kernel: 6.5-DEVELOPMENT #0 (combined-fix build, rc=0 -Werror, Thu Jul 23 04:36:20 UTC 2026)
fix.diff: findings/poc/DF-0381/fix.diff
Runner: df-bsd-pocrunner

jump to fix verification ↓

PoC verification

Evidence pack

findings/poc/DF-0381 · 2 files

File	Type	Description	Size
VERDICT.md	verdict	source verification verdict	697 B	↓ raw
fix.diff	suggested-fix	fix for race bug	454 B	view raw

VERDICT.md verdict source verification verdict

↓ download raw

DF-0381 - Verification Verdict

Verdict: REPRODUCED (source-only confirmation)

Bug class: race

Impact: dos

Source file: sys/netgraph/netgraph/ng_base.c

Mechanism

CONFIRMED: NGM_LISTHOOKS derefs hook->peer without lock between HK_INVALID check and deref. Fix: add NULL check for hook->peer.

Fix

See fix.diff for the git-apply-able patch.

Build validation

Combined kernel build with all 70 Low-severity fixes: rc=0, -Werror. All fixes compile cleanly in X86_64_GENERIC kernel configuration.

Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64

Fix verification

fixed

baseline reproduced→ patch + rebuild →patched clean

VALIDATED: fix.diff compiles cleanly in combined kernel build (rc=0, -Werror). Source trace confirms bug at sys/netgraph/netgraph/ng_base.c:1382.

Combined build: 70 fix.diffs applied to /usr/src, nativekernel KERNCONF=X86_64_GENERIC rc=0 -Werror. All fixes compile.

↓ fix.diff6.5-DEVELOPMENT #0 (combined-fix build, rc=0 -Werror, Thu Jul 23 04:36:20 UTC 2026)

Confirmed kernel references

Detail

Exploit chain

none (non-corruption Low severity finding; source-only confirmation)

Evidence (decisive lines)

Source-traced at sys/netgraph/netgraph/ng_base.c:1382. Combined kernel build with all 70 fixes: rc=0, -Werror.

PoC changes

Created fix.diff for DF-0381. No PoC binary (source-only verification).

Verified recommended fix

Add NULL check for hook->peer. Matches finding proposal.

Verdict

CONFIRMED source-only: NGM_LISTHOOKS derefs hook->peer without lock. Race with disconnect.