No re-validation of m_len>=hlen after pfil hook rewrite/dummynet re-entry
Summary
After pfil_run_hooks(:631) rewrites packet, hlen re-derived from ip->ip_vhl(:635) with no m_len check or pullup. ip_dooptions(:661) walks hlen-20 option bytes. Buggy pfil hook with inconsistent ip_vhl/m_len -> OOB read in option loop. Requires pfil module defect, not reachable via crafted packets alone.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0344 Β· 2 files| File | Type | Description | Size | |
|---|---|---|---|---|
| VERDICT.md | verdict | source verification verdict | 797 B | β raw |
| fix.diff | suggested-fix | fix for logic bug | 454 B | view raw |
DF-0344 - Verification Verdict
Verdict: REPRODUCED (source-only confirmation)
Bug class: logic
Impact: dos
Source file: sys/netinet/ip_input.c
Mechanism
CONFIRMED: After pfil_run_hooks, hlen re-derived from ip->ip_vhl without m_len check or pullup. Buggy pfil hook with inconsistent ip_vhl/m_len could cause OOB read in ip_dooptions option loop. Defense-in-depth: add m_pullup after pfil.
Fix
See fix.diff for the git-apply-able patch.
Build validation
Combined kernel build with all 70 Low-severity fixes: rc=0, -Werror.
All fixes compile cleanly in X86_64_GENERIC kernel configuration.
Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64
Fix verification
fixedVALIDATED: fix.diff compiles cleanly in combined kernel build (rc=0, -Werror). Source trace confirms bug at sys/netinet/ip_input.c:635.
Combined build: 70 fix.diffs applied to /usr/src, nativekernel KERNCONF=X86_64_GENERIC rc=0 -Werror. All fixes compile.
Confirmed kernel references
- s
- y
- s
- /
- n
- e
- t
- i
- n
- e
- t
- /
- i
- p
- _
- i
- n
- p
- u
- t
- .
- c
- :
- 6
- 3
- 5
Detail
Exploit chain
none (non-corruption Low severity finding; source-only confirmation)
Evidence (decisive lines)
Source-traced at sys/netinet/ip_input.c:635. Combined kernel build with all 70 fixes: rc=0, -Werror.
PoC changes
Created fix.diff for DF-0344. No PoC binary (source-only verification).
Verified recommended fix
Add m_pullup after pfil_run_hooks to validate packet header. Supersedes finding proposal.
Verdict
CONFIRMED source-only: After pfil hooks, hlen re-derived from ip_vhl without m_len check/pullup. Defense-in-depth.
No comments yet.