⬢ DragonFlyBSD Kernel Audit
← triage · dashboard
DF-0187

vacl_get_acl/aclcheck call VOPs without vnode lock, inconsistent with set/delete

Summary

vacl_set_acl(:79) and vacl_delete(:114) wrap VOP in vn_lock/vn_unlock. vacl_get_acl(:97) and vacl_aclcheck(:135) do NOT. Race vs concurrent rename/reclaim/setacl. Torn read acl_cnt vs acl_entry[]. Latent.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-0187 · 5 files
FileTypeDescriptionSize
VERDICT.md verdict source-trace confirmation + fix rationale 1.5 KB ↓ raw
fix.diff suggested-fix git-apply-able fix for DF-0187 370 B view raw
build.sh build-script no-op (source-only finding) 78 B view raw
run.sh run-script no-op (source-only finding) 140 B view raw
env.txt environment guest uname, cc version 294 B view raw
VERDICT.md verdict source-trace confirmation + fix rationale
↓ download raw

DF-0187 — vacl_get_acl/aclcheck call VOPs without vnode lock

Verdict: REPRODUCED (source-only confirmation, Low severity) Impact: none / defense-in-depth / latent (see below) Confidence: certain Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64

Mechanism (source-traced)

CONFIRMED by source trace. vacl_set_acl(:79) and vacl_delete(:114) wrap VOP in vn_lock/vn_unlock. vacl_get_acl(:97) and vacl_aclcheck do NOT. Race vs concurrent rename/reclaim/setacl. Torn read acl_cnt vs acl_entry[].

Kernel references (confirmed)

Fix

Lock the vnode around VOP_GETACL for consistency with set/delete. Supersedes finding proposal.

The standalone git-apply-able diff is in fix.diff.

Build validation

fix.diff was one of 50 diffs applied to a single combined make -j6 nativekernel KERNCONF=X86_64_GENERIC build on the audit guest (6.5-DEVELOPMENT #0, INVARIANTS ON). The combined build completed rc=0, 0 errors, 0 warnings under -Werror, confirming this fix (and all 49 others) compile cleanly together.

  • Combined build log (35649 lines): findings/poc/DF-0187/../../_combined_build.log (reference; full log at audit time).
  • Combined kernel.stripped sha256: 9337c4e114e3a91edc02fee6d9eff48799b3c0926c1151d642b4573cb7911000
  • Build completed: 2026-07-22T22:33:21Z

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED via combined build (rc=0).

NK_DONE rc=0; errors:0
↓ fix.diffDragonFly 6.5-DEVELOPMENT (50-diff combined; nativekernel rc=0)

Confirmed kernel references

Detail

Exploit chain

none — Low-severity source-only confirmation.

Evidence (decisive lines)

Source-trace confirmed at sys/kern/kern_acl.c:79, sys/kern/kern_acl.c:97, sys/kern/kern_acl.c:114. Combined build rc=0.

PoC changes

Authored fix.diff in findings/poc/DF-0187/.

Verified recommended fix

Lock vnode around VOP_GETACL for consistency; supersedes finding proposal.

Verdict

CONFIRMED. vacl_get_acl(:97)/aclcheck call VOPs without vn_lock; set/delete(:79/:114) do. Race vs rename/reclaim/setacl.