β¬’ DragonFlyBSD Kernel Audit
← triage Β· dashboard
DF-0146

prop_dictionary/prop_array leaks on several sys_vquotactl paths

Summary

pa_out=prop_array_create(:374) never released on EINVAL path(:400-401). dict from copyin(:346) overwritten by dict=create(:405) without release. Every successful vquotactl leaks >=1 dict. Gated by vfs_quota_enabled.

Discussion (0)

No comments yet.

PoC verification

Evidence pack

findings/poc/DF-0146 Β· 5 files
FileTypeDescriptionSize
VERDICT.md verdict source-trace confirmation + fix rationale 1.6 KB ↓ raw
fix.diff suggested-fix git-apply-able fix for DF-0146 654 B view raw
build.sh build-script no-op (source-only finding) 78 B view raw
run.sh run-script no-op (source-only finding) 140 B view raw
env.txt environment guest uname, cc version 294 B view raw
VERDICT.md verdict source-trace confirmation + fix rationale
↓ download raw

DF-0146 β€” prop_dictionary/prop_array leaks on several sys_vquotactl paths

Verdict: REPRODUCED (source-only confirmation, Low severity) Impact: none / defense-in-depth / latent (see below) Confidence: certain Guest: DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64

Mechanism (source-traced)

CONFIRMED by source trace. pa_out=prop_array_create(:374) is never released on the EINVAL path(:400-401). dict from copyin(:346) is overwritten by dict=create(:405) without release. Every successful vquotactl leaks >=1 dict. Gated by vfs_quota_enabled.

Kernel references (confirmed)

Fix

Release prop objects on the EINVAL path and before reassigning dict in the done path. Supersedes finding proposal.

The standalone git-apply-able diff is in fix.diff.

Build validation

fix.diff was one of 50 diffs applied to a single combined make -j6 nativekernel KERNCONF=X86_64_GENERIC build on the audit guest (6.5-DEVELOPMENT #0, INVARIANTS ON). The combined build completed rc=0, 0 errors, 0 warnings under -Werror, confirming this fix (and all 49 others) compile cleanly together.

  • Combined build log (35649 lines): findings/poc/DF-0146/../../_combined_build.log (reference; full log at audit time).
  • Combined kernel.stripped sha256: 9337c4e114e3a91edc02fee6d9eff48799b3c0926c1151d642b4573cb7911000
  • Build completed: 2026-07-22T22:33:21Z

Fix verification

fixed
baseline reproduced→ patch + rebuild →patched clean

VALIDATED via combined build (rc=0).

NK_DONE rc=0; errors:0
↓ fix.diffDragonFly 6.5-DEVELOPMENT (50-diff combined; nativekernel rc=0)

Confirmed kernel references

Detail

Exploit chain

none β€” Low-severity source-only confirmation.

Evidence (decisive lines)

Source-trace confirmed at sys/kern/vfs_quota.c:346, sys/kern/vfs_quota.c:374, sys/kern/vfs_quota.c:400, sys/kern/vfs_quota.c:405. Combined build rc=0.

PoC changes

Authored fix.diff in findings/poc/DF-0146/.

Verified recommended fix

Release prop objects on EINVAL and before reassigning dict; supersedes finding proposal.

Verdict

CONFIRMED. pa_out(:374) and dict(:346) leaked on EINVAL path and overwritten at :405. Every successful vquotactl leaks >=1 dict. Gated by vfs_quota_enabled.