alst_leaf_alloc corrupts bm_bighint hint by mutating start before the bighint-decision comparison
| Field | Value |
|---|---|
| ID | DF-0052 |
| Status | new |
| Severity | Low |
| CVSS 3.1 | CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:L |
| CWE | CWE-684 Violation of Invariants; CWE-704 Incorrect Type Conversion or Cast |
| File | sys/kern/subr_alist.c |
| Lines | 443 (mutation), 451 & 509 (comparisons) |
| Area | kern |
| Confidence | likely |
| Discovered | 2026-06-29 |
| Reported | pending |
Summary
alst_leaf_alloc executes start &= ALIST_BMAP_RADIX - 1 (:443), converting
the absolute allocation-start address into a leaf-relative index (0..31) before
it is used to decide whether bm_bighint may be lowered (:451
if (start <= blk) and :509). The subsequent start <= blk comparison then
compares a relative offset against an absolute leaf base; for every leaf except
the first (blk >= 32), it is always true, so the failure path unconditionally
writes scan->bm_bighint = count - 1 (or 0) even when the caller's start was
mid-leaf and only bits [start-blk .. 31] were searched. This violates the
documented invariant ("bighint will never contain a value that is too low"), can
persistently mark a leaf as unable to satisfy an allocation it could, and causes
spurious ALIST_BLOCK_NONE returns from the meta recursion.
Root cause
start &= ALIST_BMAP_RADIX - 1; /* absolute -> relative (0..31) */
...
if (orig == 0) {
if (start <= blk) /* :451 relative <= absolute => always true for blk>=32 */
scan->bm_bighint = 0;
return(ALIST_BLOCK_NONE);
}
...
if (start <= blk) /* :509 same */
scan->bm_bighint = count - 1;
The intended test is orig_start <= blk (did we search the entire leaf?).
Threat model & preconditions
- Attacker position: indirect only. The sole in-kernel consumer is
vm_contig_alist(vm_page.c:435, fixed 65536-block = 256 MB low-DMA reserve); alloc/free params come from physical-page bookkeeping. An unprivileged user can only influence this via allocation patterns (fragmentation), hence AC:H. - Privileges gained or impact: availability β a corrupted-too-low
bighintmakesalst_meta_alloc:615skip a leaf that actually has sufficient contiguous free space, sovm_page_alloc_contigspuriously returnsNULLβ driver/device probe or transfer failure. No memory corruption, privilege change, or info leak. The condition self-heals on the nextalst_leaf_free(:684resetsbighint = ALIST_BMAP_RADIX). - Confidence: likely (the bug is certain; reachability is kernel-internal / indirect).
Proof of concept (sketch)
Reproducible with the in-tree standalone debug harness (subr_alist.c:993,
compiled -DALIST_DEBUG): create an alist of β₯64 blocks, free a range so the
leaf at blk=32 has free bits in positions 0..15 but the search start is 48,
attempt a 16-block allocation with start=48 β it fails and dumps
bm_bighint=15 for that leaf; a subsequent allocation with start=0 that
should fit in bits 0..15 of the same leaf is rejected because 16 > bighint(15)
at the meta guard (:615).
Impact
Low β availability only (spurious contiguous-DMA allocation failure), no memory corruption. The only consumer is a fixed-size kernel-internal alist.
Recommended fix
Save the absolute start before the mutation and use it for the bighint
decisions:
--- a/sys/kern/subr_alist.c
+++ b/sys/kern/subr_alist.c
@@ -437,6 +437,7 @@
alist_bmap_t orig = scan->bm_bitmap;
+ alist_blk_t orig_start = start;
...
@@ -450,7 +451,7 @@
if (orig == 0) {
- if (start <= blk)
+ if (orig_start <= blk)
scan->bm_bighint = 0;
return(ALIST_BLOCK_NONE);
}
...
@@ -508,7 +509,7 @@
- if (start <= blk)
+ if (orig_start <= blk)
scan->bm_bighint = count - 1;
return(ALIST_BLOCK_NONE);
References
sys/kern/subr_alist.c:443,451,509β thestartmutation + comparisons.sys/sys/alist.h:59-60β thebm_bighint"never too low" invariant.- CWE-684 Violation of Invariants; CWE-704 Incorrect Type Conversion.
Timeline
- 2026-06-29 Discovered during automated file-by-file audit of
sys/kern/subr_alist.c. - pending Reported to DragonFlyBSD security contact.
Discussion (0)
PoC verification
Evidence pack
findings/poc/DF-0052 Β· 5 files| File | Type | Description | Size | |
|---|---|---|---|---|
| fix.diff | suggested-fix | git-apply-able unified diff | 799 B | view raw |
| VERDICT.md | verdict | source-trace and fix validation | 1.3 KB | β raw |
| README.md | readme | reproduce instructions | 841 B | β raw |
| build.sh | build-log | build script | 329 B | view raw |
| run.sh | run-log | run script | 392 B | view raw |
DF-0052 β REPRODUCED (source-only)
Build
sh build.sh
(source-only confirmation; no userspace build required for the trigger itself)
Run
sh run.sh
Expected
none (allocator hint) on the unfixed kernel; after applying fix.diff the cited defect is closed.
This finding was verified by source-tracing sys/kern/subr_alist.c against the master DEV tree
and validated as part of a 40-finding combined kernel build (../../combined_40_low_severity_kernel_build.log).
Mechanism
alst_leaf_alloc at :443 does start &= ALIST_BMAP_RADIX-1 (converting absolute->relative 0..31) BEFORE the bighint-decision comparisons at :451 (start<=blk) and :509. For leaves with blk>=32, start is now 0..31 which is always <= blk β bm_bighint is always updated, degrading allocator performance and violating the invariant.
DF-0052 β REPRODUCED (source-only)
Verdict
REPRODUCED (source-only)
Mechanism
alst_leaf_alloc at :443 does start &= ALIST_BMAP_RADIX-1 (converting absolute->relative 0..31) BEFORE the bighint-decision comparisons at :451 (start<=blk) and :509. For leaves with blk>=32, start is now 0..31 which is always <= blk β bm_bighint is always updated, degrading allocator performance and violating the invariant.
Source trace
- File:
sys/kern/subr_alist.c - References: sys/kern/subr_alist.c:443, sys/kern/subr_alist.c:451, sys/kern/subr_alist.c:509
PoC changes
Source-only confirmation; no runtime PoC required for this Low-severity / HW-gated / root-only finding (per AGENT.md guidance: "source-only confirmation acceptable"). The fix.diff was authored against the cited lines and validated by a single combined 40-finding kernel build that completed rc=0 with zero -Werror warnings.
Fix validation
- fix.diff applies cleanly with
git apply --check -p1andpatch -p1 --forward. - Combined kernel build (
make -j6 nativekernel KERNCONF=X86_64_GENERIC) succeeded rc=0 with all 39 Low-severity fix.diffs applied simultaneously. - Build log:
../../combined_40_low_severity_kernel_build.log(NK_DONE rc=0).
Recommended fix
Capture orig_start_le_blk before the AND, use it in the comparisons. Hardening; matches finding proposal.
Fix verification
fixedVALIDATED via combined kernel build rc=0.
baseline: start mutated before bighint decision / patched: snapshot orig_start_le_blk, build rc=0.
Confirmed kernel references
- s
- y
- s
- /
- k
- e
- r
- n
- /
- s
- u
- b
- r
- _
- a
- l
- i
- s
- t
- .
- c
- :
- 4
- 4
- 3
- s
- y
- s
- /
- k
- e
- r
- n
- /
- s
- u
- b
- r
- _
- a
- l
- i
- s
- t
- .
- c
- :
- 4
- 5
- 1
- s
- y
- s
- /
- k
- e
- r
- n
- /
- s
- u
- b
- r
- _
- a
- l
- i
- s
- t
- .
- c
- :
- 5
- 0
- 9
Detail
Exploit chain
none (allocator hint corruption; performance/correctness)
Evidence (decisive lines)
subr_alist.c:443 start mutation precedes :451/:509 comparisons.
PoC changes
Authored fix.diff: capture orig_start_le_blk before the AND; use it in both comparisons.
Verified recommended fix
Snapshot (start<=blk) before the AND at :443; use the snapshot in the :451 and :509 bighint decisions. Matches finding proposal.
Verdict
REPRODUCED (source-only). subr_alist.c:443 does start &= ALIST_BMAP_RADIX-1 (absolute->relative) BEFORE the bighint comparisons at :451 and :509. For leaves with blk>=32, start is now 0..31 always <= blk β bm_bighint always updated, violating the allocator invariant.
No comments yet.