DF-4691 / fix_run.log
===== fix4690 (BAR size sanity) =====
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/sys/dev/pccard/cardbus/cardbus_cis.c 2026-09-22 21:07:59.711130284 +0000
|+++ b/sys/dev/pccard/cardbus/cardbus_cis.c 2026-09-22 21:07:59.711130284 +0000
--------------------------
Patching file cardbus_fixed.c using Plan A...
Hunk #1 succeeded at 365.
done
PATCHES_APPLIED
In file included from cardbus_harness.c:104:
cardbus_extracted.inc:4:12: warning: 'struct tuple_callbacks' declared inside parameter list will not be visible outside of this definition or declaration
struct tuple_callbacks *info)
^~~~~~~~~~~~~~~
cardbus_extracted.inc:38:12: warning: 'struct tuple_callbacks' declared inside parameter list will not be visible outside of this definition or declaration
struct tuple_callbacks *info)
^~~~~~~~~~~~~~~
FIXED_BUILD_OK
--- PATCHED modes 1/2/3 (expect: counts never set = sentinel 0x42424242) ---
== DF-4690 mode 1: CIS BAR size kept when probe reads 0xffffffff ==
m1: asi=1 cis_size_field=0xfffffff0 probe=0xffffffff -> resource_list_add count = 1111638594 (0x42424242)
== DF-4690 mode 2: 1 << (ffs(0x80000000)-1) = 1 << 31 signed-overflow UB -> INT_MIN ==
m2: asi=1 cis_size_field=0x00001000 probe=0x80000000 -> resource_list_add count = 1111638594 (0x42424242)
== (known DF-1811 contrast) masked probe 0 -> ffs(0)-1 ==
m3: asi=1 cis_size_field=0x00001000 probe=0x0000000f -> resource_list_add count = 1111638594 (0x42424242)
== DF-4691: LAN NID fabricated from stale parse-buffer bytes ==
nid (PCI_IVAR_ETHADDR, cardbus.c:333) = e2:e3:e4:e5:e6:e7
===== fix4691 (funce nid length must match tuple) =====
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/sys/dev/pccard/cardbus/cardbus_cis.c 2026-09-22 21:07:59.711130284 +0000
|+++ b/sys/dev/pccard/cardbus/cardbus_cis.c 2026-09-22 21:07:59.711130284 +0000
--------------------------
Patching file cardbus_fixed.c using Plan A...
Hunk #1 succeeded at 275.
Hunk #2 succeeded at 285.
done
PATCHES_APPLIED
In file included from cardbus_harness.c:104:
cardbus_extracted.inc:4:12: warning: 'struct tuple_callbacks' declared inside parameter list will not be visible outside of this definition or declaration
struct tuple_callbacks *info)
^~~~~~~~~~~~~~~
cardbus_extracted.inc:41:12: warning: 'struct tuple_callbacks' declared inside parameter list will not be visible outside of this definition or declaration
struct tuple_callbacks *info)
^~~~~~~~~~~~~~~
FIXED_BUILD_OK
--- PATCHED mode 4 (expect: nid stays 00:00:00:00:00:00, fepresent unshifted-beyond-32) ---
== DF-4691: LAN NID fabricated from stale parse-buffer bytes ==
nid (PCI_IVAR_ETHADDR, cardbus.c:333) = 00:00:00:00:00:00
unexpected nid content
fepresent after 1<<200 (UB; x86 masks to 1<<8) = 0x0