DF-4662 / fix_run.log
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
|+++ b/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
--------------------------
Patching file ar2413_fixed.c using Plan A...
Hunk #1 succeeded at 448.
Hunk #2 succeeded at 460.
Hunk #3 succeeded at 470.
done
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
|+++ b/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
--------------------------
Patching file ar2413_fixed.c using Plan A...
Hunk #1 succeeded at 420.
Hunk #2 succeeded at 547 (offset 1 line).
done
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- a/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
|+++ b/sys/dev/netif/ath/ath_hal/ar5212/ar2413.c
--------------------------
Patching file ar2413_fixed.c using Plan A...
Hunk #1 succeeded at 469 with fuzz 2 (offset 14 lines).
done
PATCHES_APPLIED
275 ar2413_extracted.inc
In file included from ar2413_harness.c:141:
ar2413_extracted.inc: In function 'ar2413FillVpdTable':
ar2413_extracted.inc:54:15: warning: variable 'jj' set but not used [-Wunused-but-set-variable]
uint16_t ii, jj, kk;
^~
ar2413_harness.c: In function 'main':
ar2413_harness.c:256:3: warning: array subscript 4294967295 is above array bounds of 'uint16_t[128]' {aka 'short unsigned int[128]'} [-Warray-bounds]
*(uint16_t *)((char *)state_storage.pcdacTable +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
0x1FFFFFFFEull) = 0x5A5A;
~~~~~~~~~~~~~~~
FIXED_BUILD_OK
=== PATCHED mode 1 (expect: NO overflow) ===
sizeof(struct ar2413State)=2000 offsetof(pcdacTable)=72 Bank1Data=328 vpdTable_I=1484
mode=1 numPdGainsUsed(ret)=4 minPower=0x0000
DF-4660: NO overflow detected
exit=1 (1 == no overflow detected)
=== PATCHED mode 2 (expect: ret=0, no 0x5A5A propagation, sentinel minPower) ===
mapped wild pages 0xa00490000 0x200402000, seeded 0x5A5A
sizeof(struct ar2413State)=2000 offsetof(pcdacTable)=72 Bank1Data=328 vpdTable_I=1484
mode=2 numPdGainsUsed(ret)=0 minPower=0x7c7c
gainBoundaries[0] = 0x0000 (== 0x5A5A => wild read at gb+0x1FFFFFFFE, ar2413.c:484, then written to TPCRG5 by ar2413SetPowerTable:595-600)
pcdacTable[0] = 0xaaaa (== 0x5A5A => wild read at pcdacTable+0x1FFFFFFFE, ar2413.c:488, replicated across the pdadc table / 32 PHY reg writes)
minPower out = 0x7c7c (uninitialized Pmin_t2[0] stack read at ar2413.c:424; dataset carries no power data)
exit=1
=== PATCHED mode 3 (expect: completes, no SIGSEGV at wild address) ===
sizeof(struct ar2413State)=2000 offsetof(pcdacTable)=72 Bank1Data=328 vpdTable_I=1484
mode=3 numPdGainsUsed(ret)=4 minPower=0x003e
gainBoundaries[0] = 0x003e (== 0x5A5A => wild read at gb+0x1FFFFFFFE, ar2413.c:484, then written to TPCRG5 by ar2413SetPowerTable:595-600)
pcdacTable[0] = 0xaaaa (== 0x5A5A => wild read at pcdacTable+0x1FFFFFFFE, ar2413.c:488, replicated across the pdadc table / 32 PHY reg writes)
minPower out = 0x003e (uninitialized Pmin_t2[0] stack read at ar2413.c:424; dataset carries no power data)
exit=1