DF-4287 / verdict.json
{ "finding_id": "DF-4287", "status": "inconclusive", "reproduced": 0, "impact": "boot-time / attach-time kernel panic (kfree of NULL pointer) on ThinkPad firmware with a partial SMBIOS Type-1 table; no user interaction", "confidence": "certain", "verdict": "acpi_thinkpad_attach() jumps to nosmbios when EITHER smbios.system.maker or product is NULL but unconditionally calls kfreeenv() on both; kfreeenv() forwards NULL straight to kfree() and DragonFlys _kfree() panics on NULL (kern_slaballoc.c:1405). Inherited FreeBSD code that was harmless there (FreeBSD kfree(NULL) is a no-op) but panics on DragonFly. Source-certain chain; requires ThinkPad ACPI hardware with corner-case SMBIOS env, absent from this guest.", "exploit_chain": "", "evidence": "VERDICT.md proof chain: acpi_thinkpad.c:607-624 -> kern_environment.c:332-336 -> kern_slaballoc.c:1404-1406", "kernel_refs": [ "sys/dev/acpica/acpi_thinkpad/acpi_thinkpad.c:607-624", "sys/kern/kern_environment.c:332-336", "sys/kern/kern_slaballoc.c:1404-1406" ], "poc_changes": "no seed; not runtime-testable (driver never attaches on this guest)", "attempts": 0, "guest_uname": "DragonFly dfbsd 6.5-DEVELOPMENT DragonFly 6.5-DEVELOPMENT #0: Thu Jul 2 06:02:54 UTC 2026 root@dfbsd:/usr/obj/usr/src/sys/X86_64_GENERIC x86_64", "runtime_sec": 0, "guest_dirty": 0, "build_cmd": "", "run_cmd": "", "code_hash": "", "notes": "Also a candidate for kernel-wide hardening (kfreeenv tolerating NULL), but the driver-local fix is minimal and sufficient.", "recommended_fix": "NULL-guard the two kfreeenv() calls at the nosmbios label (fix.diff)", "fix_status": "not_testable", "fix_baseline_reproduced": 0, "fix_patched_reproduced": 0, "fix_verdict": "Not testable: attach path requires IBM0068/LEN0068/LEN0268 ACPI hardware. The panic chain is explicit in source (_kfree panics on NULL by design); the fix is a two-line NULL guard.", "fix_evidence": "source-level: fix.diff vs acpi_thinkpad.c:622-624" } |