⬢ DragonFlyBSD Kernel Audit
DF-3724 / fix.diff
← back to finding ↓ download raw 
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
--- a/sys/dev/netif/ix/ixgbe_x550.c
+++ b/sys/dev/netif/ix/ixgbe_x550.c
@@ -4540,6 +4540,7 @@
  **/
 s32 ixgbe_led_on_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
 {
+	s32 status;
 	u16 phy_data;
 
 	DEBUGFUNC("ixgbe_led_on_t_X550em");
@@ -4548,11 +4549,17 @@
 		return IXGBE_ERR_PARAM;
 
 	/* To turn on the LED, set mode to ON. */
-	ixgbe_read_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
-			   IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, &phy_data);
+	status = ixgbe_read_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
+				   IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
+				   &phy_data);
+	if (status != IXGBE_SUCCESS)
+		return status;
 	phy_data |= IXGBE_X557_LED_MANUAL_SET_MASK;
-	ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
-			    IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, phy_data);
+	status = ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
+				     IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
+				     phy_data);
+	if (status != IXGBE_SUCCESS)
+		return status;
 
 	/* Some designs have the LEDs wired to the MAC */
 	return ixgbe_led_on_generic(hw, led_idx);
@@ -4565,6 +4572,7 @@
  **/
 s32 ixgbe_led_off_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
 {
+	s32 status;
 	u16 phy_data;
 
 	DEBUGFUNC("ixgbe_led_off_t_X550em");
@@ -4573,11 +4581,17 @@
 		return IXGBE_ERR_PARAM;
 
 	/* To turn on the LED, set mode to ON. */
-	ixgbe_read_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
-			   IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, &phy_data);
+	status = ixgbe_read_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
+				   IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
+				   &phy_data);
+	if (status != IXGBE_SUCCESS)
+		return status;
 	phy_data &= ~IXGBE_X557_LED_MANUAL_SET_MASK;
-	ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
-			    IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, phy_data);
+	status = ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
+				     IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE,
+				     phy_data);
+	if (status != IXGBE_SUCCESS)
+		return status;
 
 	/* Some designs have the LEDs wired to the MAC */
 	return ixgbe_led_off_generic(hw, led_idx);