# DF-2509 — ast_reinit frees softc/NULLs ivars; ast_detach then NULL-derefs stp->cdev1 (panic)

## Verdict
NOT REPRODUCED (hardware / trigger gated). The cited vulnerable code path exists
in `sys/dev/disk/nata/atapi-tape.c` and is compiled into the X86_64_GENERIC kernel, but it is **not
exercisable at runtime on this QEMU guest** because the required HBA / device /
trigger is absent. Confidence in the source bug itself: **certain**.

## Why it cannot be reproduced here (the gate)
Hard-gated: needs an ATAPI tape (ast). No /dev/ast* exists on the guest; ast_reinit is never called at runtime.

See `env.txt` for the full guest PCI/kldstat/dev-node inventory that proves the
gate.

## The bug is real in source (traced line-by-line)
Cited path:
- sys/dev/disk/nata/atapi-tape.c:202-213
- sys/dev/disk/nata/atapi-tape.c:172-189
- The vulnerable construct is present verbatim in the current master source
  (confirmed by direct read of the cited lines during verification).
- A defense-in-depth `fix.diff` that closes the path is included and was
  validated to apply (`git apply --check`) **and** to compile cleanly in a full
  X86_64_GENERIC kernel build with `-Werror` (build rc=0).

## Fix
Mirror ast_detach's cleanup in ast_reinit (destroy_dev cdev1/cdev2, ata_fail_requests, dev_ops_remove_minor, devstat_remove_entry) before kfree, so ast_detach sees NULL ivars and returns cleanly.

The standalone git-apply-able diff is `fix.diff`.

## Reproduce
`./build.sh && ./run.sh` — both are no-ops on this guest by design (the gate
holds). Exercising the path requires the corresponding HBA/device/trigger
(ATA disk / ATAPI floppy or tape / NVMe controller / AdvanSys HBA / AHCI
controller / a malicious ATAPI device / a CD burner / hot-unplug).

## Status
status: not_reproduced  | reproduced: 0 | impact: none (HW-gated)
fix_status: not_testable (path cannot run on this guest; diff applies + compiles)