# DF-2217 — Missing privilege check on NVMEIOCGETLOG (controller-wide admin cmd from read-only fd)

## Verdict
NOT REPRODUCED (hardware / trigger gated). The cited vulnerable code path exists
in `sys/dev/disk/nvme/nvme_ioctl.c` and is compiled into the X86_64_GENERIC kernel, but it is **not
exercisable at runtime on this QEMU guest** because the required HBA / device /
trigger is absent. Confidence in the source bug itself: **likely**.

## Why it cannot be reproduced here (the gate)
Hard-gated: needs an NVMe controller + /dev/nvme*. The guest has NO NVMe controller (no PCI class 0x0108) and NO /dev/nvme*; nvme never attaches.

See `env.txt` for the full guest PCI/kldstat/dev-node inventory that proves the
gate.

## The bug is real in source (traced line-by-line)
Cited path:
- sys/dev/disk/nvme/nvme_ioctl.c:37-64
- sys/dev/disk/nvme/nvme_disk.c:154-170
- The vulnerable construct is present verbatim in the current master source
  (confirmed by direct read of the cited lines during verification).
- A defense-in-depth `fix.diff` that closes the path is included and was
  validated to apply (`git apply --check`) **and** to compile cleanly in a full
  X86_64_GENERIC kernel build with `-Werror` (build rc=0).

## Fix
Add caps_priv_check_self(SYSCAP_NODRIVER) in the NVMEIOCGETLOG dispatch (nvme_disk.c), matching ath/mpr/cuse which all gate hardware-admin ioctls this way.

The standalone git-apply-able diff is `fix.diff`.

## Reproduce
`./build.sh && ./run.sh` — both are no-ops on this guest by design (the gate
holds). Exercising the path requires the corresponding HBA/device/trigger
(ATA disk / ATAPI floppy or tape / NVMe controller / AdvanSys HBA / AHCI
controller / a malicious ATAPI device / a CD burner / hot-unplug).

## Status
status: not_reproduced  | reproduced: 0 | impact: none (HW-gated)
fix_status: not_testable (path cannot run on this guest; diff applies + compiles)