⬢ DragonFlyBSD Kernel Audit
DF-2216 / fix.diff
← back to finding ↓ download raw 
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
--- a/sys/dev/drm/linux_dmi.c
+++ b/sys/dev/drm/linux_dmi.c
@@ -35,30 +35,50 @@
 bool
 dmi_match(enum dmi_field f, const char *str)
 {
-	const char *s = NULL;
+	char *s = NULL;
 
 	switch (f) {
 	case DMI_NONE:
 		break;
 	case DMI_SYS_VENDOR:
 		s = kgetenv("smbios.system.maker");
-		if (s != NULL && !strcmp(s, str))
-			return true;
+		if (s != NULL) {
+			if (!strcmp(s, str)) {
+				kfreeenv(s);
+				return true;
+			}
+			kfreeenv(s);
+		}
 		break;
 	case DMI_BOARD_VENDOR:
 		s = kgetenv("smbios.planar.maker");
-		if (s != NULL && !strcmp(s, str))
-			return true;
+		if (s != NULL) {
+			if (!strcmp(s, str)) {
+				kfreeenv(s);
+				return true;
+			}
+			kfreeenv(s);
+		}
 		break;
 	case DMI_PRODUCT_NAME:
 		s = kgetenv("smbios.system.product");
-		if (s != NULL && !strcmp(s, str))
-			return true;
+		if (s != NULL) {
+			if (!strcmp(s, str)) {
+				kfreeenv(s);
+				return true;
+			}
+			kfreeenv(s);
+		}
 		break;
 	case DMI_BOARD_NAME:
 		s = kgetenv("smbios.planar.product");
-		if (s != NULL && !strcmp(s, str))
-			return true;
+		if (s != NULL) {
+			if (!strcmp(s, str)) {
+				kfreeenv(s);
+				return true;
+			}
+			kfreeenv(s);
+		}
 		break;
 	default:
 		return false;