# DF-1854 Verification

## Verdict
**SOURCE-CONFIRMED, INCONCLUSIVE-RUNTIME (HW/module gated).**

The cited defect exists in the audited source at `sys/dev/drm/amd/amdgpu/amdgpu_psp.c:254-255`. Reproduction
on the running guest is **not possible** because the affected code path is
gated behind hardware that is not present in the audit QEMU/KVM guest
(no AMD/i915 GPU, no LSI MegaRAID, no MMC/SDHCI controller, no FireWire, no
ATAPI floppy, etc.) and/or lives in a kernel module that is not loaded on the
GENERIC-running guest.

## Mechanism (source-only confirmation)
amdgpu (not in GENERIC, no AMD HW). Source: psp_asd_load at L254-255 memset(fw_pri_buf,0,PSP_1_MEG); memcpy(fw_pri_buf,asd_start_addr,asd_ucode_size). fw_pri_buf allocated at L350-354 size PSP_1_MEG. asd_ucode_size from le32 (ucode_size_bytes) in firmware header — if >PSP_1_MEG, heap overflow.

## Recommended fix
Reject asd_ucode_size > PSP_1_MEG before the memcpy.

The full `git apply`-able diff lives in `fix.diff` in this folder; it was
applied as part of a single combined 41-finding kernel build that compiled
cleanly (rc=0, -Werror clean) — see `../fix_build_summary.txt`.

## Build validation
* `git apply --check` on this fix.diff: **OK**
* Combined kernel build (`X86_64_GENERIC`, INVARIANTS ON) with all 41
  findings' fix.diffs applied: **rc=0**, no warnings, no errors.
* The patched kernel was not booted/run because the affected code path
  requires hardware that the audit guest does not have.
