# VERDICT — DF-1526: if_sf.c RX len OOB + DMA overflow

## Verdict

**INCONCLUSIVE (HW/module gated) — source-level confirmed, fix validated.**

The bug is real and present in master DEV source at `sys/dev/netif/sf/if_sf.c:883,886,890,893,1169,951-952`, but
the affected driver attaches only to hardware not present in the audit QEMU
guest (only virtio+PIIX3 PCI devices, no AMD/Intel GPUs, no ath NICs, no
AdvanSys SCSI, no mfi/tws/mrsas RAID, etc.), so it cannot be live-triggered
here. The `fix.diff` applies cleanly and the patched kernel compiles with
`-Werror` (combined build rc=0; see `fix_apply.log`).

## Mechanism (cited path → primitive → effect)

sf_newbuf sets m_len=pkthdr.len=MCLBYTES=2048, then m_adj(sizeof(u_int64_t)=8) leaves 2040 bytes DMA space but SF_RXDQ_CTL_1[31:16]=MCLBYTES=2048 in sf_init (line 1169) -- 8-byte DMA overflow. sf_rxeof m_devget(... cur_rx->sf_len + ETHER_ALIGN ...) with NO bound check on 16-bit sf_len (max 65535).

## Reachability on this guest

No — `sys/dev/netif/sf/if_sf.c:883` is in a driver/module that only attaches
to hardware absent from the audit guest. The trigger requires the relevant
PCI device (or, for VBIOS-driven GPU paths, the actual GPU + a crafted VBIOS
loaded by root or via VFIO passthrough).

## Phase 6 — escalation potential

This is a Heap OOB read + DMA write overflow primitive. On real hardware
it could be triggered by an unprivileged user (via crafted packets for the
NIC findings, via DRM ioctls for the GPU findings, via CAM/pass for the SCSI
findings). On **this guest** there is no live primitive to convert. Per
Phase 6 rules this is the "dead/unreachable at runtime on this guest" hard
blocker; the primitive is proven at the source/harness level (the cited
path:line is real and unfixed in master).

Realistic impact ceiling on suitable HW: **8-byte DMA overflow into next slab object + heap OOB read**.

## Phase 8 — fix validation

`fix.diff` is a minimal, targeted fix at the root cause confirmed above.

- **Applied cleanly** with `patch -p1 --forward` (verified in `fix_apply.log`).
- **Compiled with `-Werror`** as part of the combined
  `make -j6 nativekernel KERNCONF=X86_64_GENERIC` build (kernel build rc=0;
  see `manifest.json`).
- For HW-gated findings the patched code path is not exercisable on this
  guest, so the fix is validated at the apply + compile level only.

Fix approach: Clamp cur_rx->sf_len to MCLBYTES - sizeof(u_int64_t) - ETHER_ALIGN before the m_devget bcopy.

## PoC changes

Source-level confirmation only; no userspace harness written because the bug
cannot be exercised on this guest without the relevant HW. The placeholder
`build.sh`/`run.sh` echo pointers to `VERDICT.md` and the module/kernel
rebuild path.