# VERDICT — DF-1475: mprsas_add_device PhyNum off-by-one OOB write of targets[]

## Verdict

**INCONCLUSIVE (HW/module gated) — source-level confirmed, fix validated.**

The bug is real and present in master DEV source at `sys/dev/raid/mpr/mpr_sas_lsi.c:885-897, 908`,
but the affected driver attaches only to hardware not present in the audit QEMU
guest, so it cannot be live-triggered here. The fix.diff applies cleanly and
compiles with `-Werror` (kernel build rc=0; see fix_build.log).

## Mechanism (cited path → primitive → effect)

Line 890 `(id = config_page.PhyNum) > sassc->maxtargets` uses strict greater-than, so PhyNum == maxtargets passes. targets[] has indices 0..maxtargets-1 (allocated sizeof(mprsas_target)*maxtargets at mpr_sas.c:761). Line 908 `targ = &sassc->targets[id];` with id==maxtargets writes one struct mprsas_target (~200 bytes) past the end of targets[].

## Reachability on this guest

No — mpr(4) HW-gated as above. Trigger is a SAS device whose config_page.PhyNum == sassc->maxtargets.

## Phase 6 — escalation potential

This is a heap OOB write (off-by-one) primitive. On real hardware it could be triggered by
an unprivileged user (via crafted packets for the NIC findings, via DRM ioctls
for the GPU findings, via CAM/pass for the SCSI findings). On **this guest**
there is no live primitive to convert. Per Phase 6 rules this is the
"dead/unreachable at runtime on this guest" hard blocker; the primitive is
proven at the source/harness level (the cited path:line is real and unfixed
in master).

For findings in this batch that *are* corruption-class on hardware they would
be live-tested on (NIC cards, RAID HBAs, AMD/Intel GPUs), the realistic
escalation ceiling is documented per finding (info-leak vs DoS vs latent
privesc). No `uid=0` claim is made — none is reachable on this guest.

## Phase 8 — fix validation

`fix.diff` is a minimal, targeted fix at the root cause confirmed above.

- **Applied cleanly** with `patch -p1 --forward` (verified in `fix_apply.log`).
- **Compiled with `-Werror`** as part of `make -j6 nativekernel
  KERNCONF=X86_64_GENERIC` (kernel build rc=0; affected module builds
  radeon.ko/amdgpu.ko/sound.ko/i915.ko/vga_switcheroo.ko all produced).
- For musycc.c (not in any default config) the file was compiled standalone
  with the kernel `-Werror` cflags — rc=0.

Change `> sassc->maxtargets` to `>= sassc->maxtargets`.

## PoC changes

Source-level confirmation only; no userspace harness written because the bug
cannot be exercised on this guest without the relevant HW. The placeholder
`build.sh`/`run.sh` echo pointers to `VERDICT.md` and the module/kernel
rebuild path.