# VERDICT -- DF-1369

## Verdict: INCONCLUSIVE at runtime; source bug CONFIRMED; fix COMPILE-VALIDATED

**Citations confirmed:**
  - sys/dev/raid/mps/mps.c:1515
  - sys/dev/raid/mps/mps.c:1581
  - sys/dev/raid/mps/mps.c:847
  - sys/dev/raid/mps/mps.c:849

### Is the bug real? -- YES (source trace)

mps_intr_locked() does `cm = &sc->commands[desc->SCSIIOSuccess.SMID]` and the
    same for AddressReply.SMID, with NO bounds/zero check. SMID is u16 from DMA.
sc->commands is allocated as `num_reqs` entries (kmalloc at :847) and the init
loop starts at i=1, so commands[0] is M_ZERO'd (cm_sc==NULL). SMID=0 -> NULL
deref panic; SMID>=num_reqs -> heap OOB on cm_reply (write) and cm_complete
(function pointer call). Malicious/buggy HBA can supply any SMID value.

### Can it be reproduced on this guest? -- NO (hardware-gated)

No LSI SAS HBA in PCI list (no class=0x010700); mps.ko not in kldstat.

The mps driver is compiled into `X86_64_GENERIC`, is not loaded, and cannot be `kldload`'d by an unprivileged user (kldload is root-only). Even loaded, it would not attach without the hardware.
Therefore the vulnerable code is unreachable at runtime here. Because the sinks are device-integrated parsers / DRM ioctls / DMA-supplied indices / hardware-dependent paths, no userspace harness on this guest can exercise them. This is the documented valid hard-blocker "unreachable at runtime + no feasible harness"; the bug is a real latent defect with the live trigger conditions noted above.

### No escalation chain (and why that is correct here)
There is no memory-corruption primitive to escalate on this guest: the corruption sinks live entirely inside the not-attached driver behind hardware that is absent. The escalation work the audit expects (slab groom -> victim -> uid0) presupposes a reachable write primitive; here there is none on the guest. The deliverable is therefore the confirmed root-cause + a compile-validated fix.

### Fix (fix.diff) -- authored and COMPILE-VALIDATED
Added a `SMID == 0 || SMID >= sc->num_reqs` validation block before each of the
two cm lookups, with a device_printf and cm=NULL/break so mps_complete_command
is skipped. (matches finding proposal.)

The fix was applied to in-guest `/usr/src` (all hunks applied cleanly) and the
kernel was rebuilt with `make -j6 nativekernel KERNCONF=X86_64_GENERIC` => rc=0 (see `build_fix.log`). No warnings or errors in the patched translation unit. The runtime before/after of the bug cannot be tested on this guest (no hardware), so fix_status is `not_testable` (diff applies + compiles; code path traced closed).

### Why not `not_reproduced` (false-positive)?
This is NOT a false positive. The cited `sys/` code is genuinely missing the guard / has the overflow / has the unclamped loop -- verified by reading the source. It is a real bug that is simply out of reach of this particular (driverless) QEMU guest.