# DF-1369 -- Unvalidated SMID in mps reply descriptors -> NULL deref + heap OOB

**File:** `sys/dev/raid/mps/mps.c:1515`
**Class:** memory corruption (heap OOB / OOB write / OOB read)

## Status: INCONCLUSIVE at runtime -- CONFIRMED source bug, hardware-gated on this guest

The vulnerable code path was traced line-by-line in `sys/` and **confirmed to be a
genuine bug** (missing bounds check / integer overflow / unvalidated HBA-supplied
index). However it is **not exercisable on the DragonFly audit guest** because the
guest has no mps hardware:

- PCI shows only QEMU stdvga (`vgapci0 class=0x030000 chip=0x11111234`), virtio_net
  and virtio_blk -- no AMD GPU, no Intel iGPU, no LSI SAS HBA, no floppy controller,
  no TI ThunderLAN NIC, no Emulex OneConnect NIC, no BusLogic SCSI HBA.
- The mps driver (whether a loadable .ko or compiled-in) never attaches.
- `/dev/fd0`, `/dev/dri`, `/dev/dsp*` do not exist on this guest.

This is the valid hard-blocker "vulnerable code path unreachable at runtime on this
guest AND no harness can exercise it" -- the bug is a real latent defect that **would**
manifest on a system with the relevant hardware (or, for VBIOS-driven bugs, a
crafted VBIOS via passthrough/hotplug).

## Mechanism (confirmed by source trace)

mps_intr_locked() does `cm = &sc->commands[desc->SCSIIOSuccess.SMID]` and the
    same for AddressReply.SMID, with NO bounds/zero check. SMID is u16 from DMA.
sc->commands is allocated as `num_reqs` entries (kmalloc at :847) and the init
loop starts at i=1, so commands[0] is M_ZERO'd (cm_sc==NULL). SMID=0 -> NULL
deref panic; SMID>=num_reqs -> heap OOB on cm_reply (write) and cm_complete
(function pointer call). Malicious/buggy HBA can supply any SMID value.

## Live trigger conditions
Requires the mps hardware (and the driver loaded). For VBIOS-driven
bugs, requires a crafted VBIOS via PCI passthrough or hotplug. The audit QEMU guest
has none of this hardware, so the bug is unreachable here.

## Fix
A standalone, `git apply`-able fix is in `fix.diff`. **Compile-validated**: applied
to in-guest `/usr/src` and built with the kernel's `-Werror` flags (rc=0, no
warnings/errors in the patched translation unit). See `build_fix.log`.

Added a `SMID == 0 || SMID >= sc->num_reqs` validation block before each of the
two cm lookups, with a device_printf and cm=NULL/break so mps_complete_command
is skipped. (matches finding proposal.)

## Reproduce / validate
```
# 1. Confirm the bug site (read-only source trace):
grep -n ... sys/dev/raid/mps/mps.c

# 2. Compile-validate the fix on the audit guest:
scp -F dfbsd-qemu/config findings/poc/DF-1369/fix.diff dfbsd:/root/DF-1369.fix.diff
./dfbsd-qemu/vm.sh run_root 'cd /usr/src && patch -p1 --forward < /root/DF-1369.fix.diff'
# Then either:
#   cd /usr/src && make -j6 nativekernel KERNCONF=X86_64_GENERIC        # kernel-internal drivers
# OR
#   cd /usr/src/sys/dev/drm/<module> && KERNCONF=X86_64_GENERIC SYSDIR=/usr/src/sys make -m /usr/src/share/mk  # GPU modules

# 3. (requires real hardware) Exercise the bug: attach the HW and trigger.
```