# VERDICT -- DF-1362

## Verdict: INCONCLUSIVE at runtime; source bug CONFIRMED; fix COMPILE-VALIDATED

**Citations confirmed:**
  - sys/dev/raid/mps/mps_user.c:1583
  - sys/dev/raid/mps/mps_user.c:1593
  - sys/dev/raid/mps/mps_user.c:1595

### Is the bug real? -- YES (source trace)

The bounds check `if (diag_read_buffer->StartingOffset + diag_read_buffer->BytesToRead >
    pBuffer->size)` uses two u32 fields whose sum wraps mod 2^32 in C's unsigned
arithmetic. StartingOffset=0xFFFFFFFF and BytesToRead=2 makes the LHS evaluate to 1,
which is <= pBuffer->size, so the check passes; then pData = fw_diag_buffer +
0xFFFFFFFF and copyout reads ~4GiB out of the DMA allocation (wild OOB read).
Reached from the MPS_DIAG_READ_BUFFER ioctl path which only requires the diag
capability common on LSI SAS1068/2008 controllers.

### Can it be reproduced on this guest? -- NO (hardware-gated)

kldstat shows no mps/mpr module loaded; the LSI SAS HBA is absent (no PCI class=0x010700 device, only virtio_pci storage).

The mps driver is compiled into `X86_64_GENERIC`, is not loaded, and cannot be `kldload`'d by an unprivileged user (kldload is root-only). Even loaded, it would not attach without the hardware.
Therefore the vulnerable code is unreachable at runtime here. Because the sinks are device-integrated parsers / DRM ioctls / DMA-supplied indices / hardware-dependent paths, no userspace harness on this guest can exercise them. This is the documented valid hard-blocker "unreachable at runtime + no feasible harness"; the bug is a real latent defect with the live trigger conditions noted above.

### No escalation chain (and why that is correct here)
There is no memory-corruption primitive to escalate on this guest: the corruption sinks live entirely inside the not-attached driver behind hardware that is absent. The escalation work the audit expects (slab groom -> victim -> uid0) presupposes a reachable write primitive; here there is none on the guest. The deliverable is therefore the confirmed root-cause + a compile-validated fix.

### Fix (fix.diff) -- authored and COMPILE-VALIDATED
Rewrote the check overflow-safe: `StartingOffset > pBuffer->size ||
    BytesToRead > pBuffer->size - StartingOffset`. (matches finding proposal;
the proposal explicitly suggested this rewrite.)

The fix was applied to in-guest `/usr/src` (all hunks applied cleanly) and the
kernel was rebuilt with `make -j6 nativekernel KERNCONF=X86_64_GENERIC` => rc=0 (see `build_fix.log`). No warnings or errors in the patched translation unit. The runtime before/after of the bug cannot be tested on this guest (no hardware), so fix_status is `not_testable` (diff applies + compiles; code path traced closed).

### Why not `not_reproduced` (false-positive)?
This is NOT a false positive. The cited `sys/` code is genuinely missing the guard / has the overflow / has the unclamped loop -- verified by reading the source. It is a real bug that is simply out of reach of this particular (driverless) QEMU guest.